Skip to content

Collect ghsa severity #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbs2001 merged 4 commits into from
Feb 23, 2021
+228 −132
Merged

Collect ghsa severity #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56cea9c
Add CVSSv3.1 Qualitative Severity Rating scoring system
sbs2001 Feb 17, 2021
2ee4430
Collect severities at github importer
sbs2001 Feb 17, 2021
22142c0
Modify github importer tests to account for collecting severites
sbs2001 Feb 17, 2021
55f1d84
Remove debug print statement
sbs2001 Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions vulnerabilities/importers/github.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,13 @@
from vulnerabilities.data_source import DataSource
from vulnerabilities.data_source import DataSourceConfiguration
from vulnerabilities.data_source import Reference

from vulnerabilities.data_source import VulnerabilitySeverity
from vulnerabilities.package_managers import MavenVersionAPI
from vulnerabilities.package_managers import NugetVersionAPI
from vulnerabilities.package_managers import ComposerVersionAPI
from vulnerabilities.package_managers import PypiVersionAPI
from vulnerabilities.package_managers import RubyVersionAPI
from vulnerabilities.severity_systems import scoring_systems

# set of all possible values of first '%s' = {'MAVEN','COMPOSER', 'NUGET', 'RUBYGEMS', 'PYPI'}
# second '%s' is interesting, it will have the value '' for the first request,
Expand All @@ -63,6 +64,7 @@
references {
url
}
severity
}
package {
name
Expand Down Expand Up @@ -222,9 +224,24 @@ def process_response(self) -> List[Advisory]:
vuln_references = self.extract_references(adv["node"]["advisory"]["references"])
vuln_desc = adv["node"]["advisory"]["summary"]

for vuln in adv["node"]["advisory"]["identifiers"]:
if vuln["type"] == "CVE":
cve_ids.add(vuln["value"])
for identifier in adv["node"]["advisory"]["identifiers"]:
# collect CVEs
if identifier["type"] == "CVE":
cve_ids.add(identifier["value"])

# attach the GHSA with severity score
if identifier["type"] == "GHSA":
for ref in vuln_references:
if ref.reference_id == identifier["value"]:
ref.severities = [
VulnerabilitySeverity(
system=scoring_systems["cvssv3.1_qr"],
value=adv["node"]["advisory"]["severity"]
)
]
# Each Node has only one GHSA, hence exit after attaching
# score to this GHSA
break

for cve_id in cve_ids:
adv_list.append(
Expand Down
6 changes: 6 additions & 0 deletions vulnerabilities/severity_systems.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,11 @@ def as_score(self, value):
identifier="avgs",
name="Archlinux Vulnerability Group Severity",
url="https://wiki.archlinux.org/index.php/Bug_reporting_guidelines#Severity"
),
"cvssv3.1_qr": ScoringSystem(
identifier="cvssv3.1_qr",
name="CVSSv3.1 Qualitative Severity Rating",
url="https://www.first.org/cvss/specification-document",
notes="A textual interpretation of severity. Has values like HIGH, MODERATE etc"
)
}
15 changes: 10 additions & 5 deletions vulnerabilities/tests/test_data/github_api/response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
{
"url":"https://github.com/advisories/GHSA-qcxh-w3j9-58qr"
}
]
],
"severity": "MODERATE"
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand All @@ -46,7 +47,8 @@
{
"url":"https://github.com/advisories/GHSA-qcxh-w3j9-58qr"
}
]
],
"severity": "HIGH"
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand All @@ -72,7 +74,8 @@
{
"url":"https://github.com/advisories/GHSA-c9hw-wf7x-jp9j"
}
]
],
"severity": "LOW"
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand All @@ -98,7 +101,8 @@
{
"url":"https://github.com/advisories/GHSA-c9hw-wf7x-jp9j"
}
]
],
"severity": "MODERATE"
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand All @@ -124,7 +128,8 @@
{
"url":"https://github.com/advisories/GHSA-c9hw-wf7x-jp9j"
}
]
],
"severity": "LOW"
},
"package": {
"name": "org.apache.tomcat.embed:tomcat-embed-core"
Expand Down
Loading