Skip to content

Ingest npm data through github api #1025#1027

Merged
pombredanne merged 2 commits into
aboutcode-org:mainfrom
TG1999:fix/1025
Dec 28, 2022
Merged

Ingest npm data through github api #1025#1027
pombredanne merged 2 commits into
aboutcode-org:mainfrom
TG1999:fix/1025

Conversation

@TG1999

@TG1999 TG1999 commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999 TG1999 changed the title Ingest npm data through github api Ingest npm data through github api #1025 Dec 5, 2022
@TG1999 TG1999 linked an issue Dec 7, 2022 that may be closed by this pull request
@pombredanne pombredanne added this to the v32.0.0 milestone Dec 8, 2022

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... See a few comments inline

Comment thread vulnerabilities/importers/github.py
Comment thread vulnerabilities/tests/test_data/github_api/npm-expected.json Outdated
Comment thread vulnerabilities/tests/test_data/github_api/npm-expected.json
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you ++

@pombredanne
pombredanne merged commit 92d1bf0 into aboutcode-org:main Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable NPM support in Github importer

2 participants