Skip to content

sync: port upstream iOS terminal Enter input encoding (#4043) - #163

Merged
aaditagrawal merged 1 commit into
mainfrom
sync/20260717-ios-terminal
Jul 17, 2026
Merged

sync: port upstream iOS terminal Enter input encoding (#4043)#163
aaditagrawal merged 1 commit into
mainfrom
sync/20260717-ios-terminal

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Jul 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • Ports upstream #4043: iOS terminal Enter/Return normalized to CR (\r); hardware key revision bumped to 3.
  • Preserves fork: Android terminal hardware-key path unchanged.

Validation

  • Mobile typecheck passed in port worktree; tip stack vp check / vp run typecheck passed
  • vp run lint:mobile blocked locally by SourceKit/swiftlint environment (pre-existing)

Stack: 4 of 6; depends on #162.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aaditagrawal, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a7941017-3162-4ca7-8728-90db4e40245f

📥 Commits

Reviewing files that changed from the base of the PR and between 37aa437 and 069536c.

📒 Files selected for processing (3)
  • apps/mobile/modules/t3-terminal/ios/T3TerminalModule.swift
  • apps/mobile/modules/t3-terminal/ios/T3TerminalView.swift
  • apps/mobile/src/features/terminal/NativeTerminalSurface.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/20260717-ios-terminal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 effective changed lines (test files excluded in mixed PRs). label Jul 17, 2026
@aaditagrawal

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@aaditagrawal
aaditagrawal force-pushed the sync/20260717-composer-images branch from e1784f1 to 60a649c Compare July 17, 2026 10:37
@aaditagrawal
aaditagrawal force-pushed the sync/20260717-ios-terminal branch 2 times, most recently from 16b121a to ece573a Compare July 17, 2026 10:38
@aaditagrawal
aaditagrawal force-pushed the sync/20260717-composer-images branch from 60a649c to 0c3f54b Compare July 17, 2026 10:38

aaditagrawal commented Jul 17, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Jul 17, 10:56 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 17, 11:02 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 17, 11:02 AM UTC: @aaditagrawal merged this pull request with Graphite.

@aaditagrawal
aaditagrawal changed the base branch from sync/20260717-composer-images to graphite-base/163 July 17, 2026 10:59
@aaditagrawal
aaditagrawal changed the base branch from graphite-base/163 to main July 17, 2026 11:00
@aaditagrawal
aaditagrawal force-pushed the sync/20260717-ios-terminal branch from ece573a to 069536c Compare July 17, 2026 11:01
@aaditagrawal
aaditagrawal merged commit d0fbba5 into main Jul 17, 2026
12 checks passed
aaditagrawal added a commit that referenced this pull request Jul 17, 2026
… (#164)

## What changed

- Ports upstream `pingdotgg#4021`: native mobile share target (share extension plugin, IncomingShare inbox/model/presentation, NewTask draft wiring).
- Preserves fork: personal-team `appleTeamId` conditional, Connect onboarding / legal modal / CloudAuth / Appearance stack wiring; share extension disabled for personal-team builds.

## Validation

- `vp check` and full typecheck passed in port worktree and tip
- Share unit tests blocked by local vitest/`@effect/vitest` env skew during isolated port; tip typecheck includes mobile

Stack: 5 of 6; depends on #163.
@aaditagrawal
aaditagrawal deleted the sync/20260717-ios-terminal branch August 1, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant