examples/suspense: buffer the slot channel so producers can't leak#1401
Open
c-tonneslan wants to merge 1 commit into
Open
examples/suspense: buffer the slot channel so producers can't leak#1401c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
The example creates an unbuffered channel for the three deferred slots. If the client disconnects before the page's for-range loop reads from it, the producer goroutines block on send forever and the goroutines (plus their captured component data) stay pinned. The wait group already knows there are exactly three sends, so buffer the channel by 3. Each goroutine can finish even if no one reads. Closes a-h#1352 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #1352: the suspense example creates an unbuffered channel for the three deferred slots. Each producer goroutine sends one
SlotContentsvalue to it, and thePagetemplate reads them viafor sc := range data. If the client disconnects (ortempl.WithStreaming()aborts) before the for-range loop has read every value, the producer goroutines block on send forever and the goroutines (plus thetempl.Componentthey captured) stay pinned for the life of the process.The
WaitGroupalready states the producer count up front (three slots,wg.Add(3)), so the bound is known. Buffer the channel by 3, then a producer always completes even if no one is reading.Updated the templ source and the generated
main_templ.go; runningtempl generateagain won't change anything else.Closes #1352.