AIESW-33855 [XRT-SMI] [AIE4] dipslay only relevant data in -telemetry and -preemption reports - #9972
Open
AShivangi wants to merge 7 commits into
Open
AIESW-33855 [XRT-SMI] [AIE4] dipslay only relevant data in -telemetry and -preemption reports#9972AShivangi wants to merge 7 commits into
AShivangi wants to merge 7 commits into
Conversation
Signed-off-by: Agarwal <sagarw@amd.com>
aktondak
approved these changes
Aug 10, 2026
AShivangi
marked this pull request as ready for review
August 12, 2026 17:15
AShivangi
requested review from
chvamshi-xilinx,
rbramand-xilinx and
stsoe
as code owners
August 12, 2026 17:15
Drop redundant 'virtual' on overridden clearScreenBeforeReports() in ReportPreemption.h and ReportTelemetry.h, and suppress the unavoidable ioctl vararg warning in linux/sysinfo.h. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Agarwal <sagarw@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
rchane
approved these changes
Aug 12, 2026
Signed-off-by: Agarwal <sagarw@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
AIESW-33855 [XRT-SMI] [AIE4] dipslay only relevant data in -telemetry and -preemption reports
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
When driver exposed the new virtual contexts, xrt-smi started displaying long reports
How problem was solved, alternative solutions (if any) and why they were rejected
When a single report is run interactively (preemption or telemetry), it clears the current screen and prints the rows that fit on the terminal.
All of the following must be true:
Behavior when triggered (interactive, no --batch)
• The visible screen is cleared. This preserves scrollback.
• We query the terminal size (rows) — GetConsoleScreenBufferInfo on Windows, ioctl(TIOCGWINSZ) on Linux — with a conservative 24×80 fallback if it can't be determined.
• The report is trimmed to the rows that fit.
Behavior when NOT triggered
There are three cases, with two distinct outcomes:
Behavior:
Risks (if any) associated the changes in the commit
It touches
Report.handXBUtilities, so it can affect examine reports. However, I have done thorough manual testing.What has been tested and how, request additional testing if necessary
Tested on windows
Linux testing TBD
Documentation impact (if any)
Update xrt-smi User Guide