Skip to content

Fix RTL layout on Connectors admin screen #11247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tejas0306 wants to merge 2 commits into from
Closed

Fix RTL layout on Connectors admin screen #11247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd8a965
Fix RTL layout on Connectors admin screen
tejas0306 Mar 13, 2026
6e2e02e
fix: remove extra action
tejas0306 Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/wp-admin/options-connectors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,28 @@
$title = __( 'Connectors' );

// Set parent file for menu highlighting.
$parent_file = 'options-general.php';
$parent_file = 'options-general.php';
$submenu_file = 'options-connectors.php';

@mukeshpanchal27 mukeshpanchal27 Mar 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$submenu_file = 'options-connectors.php';

@tejas0306 tejas0306 Mar 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Thanks for the review.

I’ve removed the extra admin_head action and the inline script so the patch no longer adds additional actions or inline styles.

The remaining fix focuses only on the RTL menu arrow issue on the Connectors screen.

Please let me know if you’d prefer a different approach.

@tejas0306 tejas0306 Mar 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 I’d recommend keeping this line.

$submenu_file is the standard way in wp-admin to mark the active submenu item. Without it, the "Connectors" item under Settings is not highlighted when visiting the page.

This follows the same pattern used in other options pages such as options-general.php.


require_once ABSPATH . 'wp-admin/admin-header.php';

// Render the Connectors page.
wp_options_connectors_wp_admin_render_page();

if ( is_rtl() ) {
?>
<style>
.rtl .admin-ui-page__header > div > div:first-child {
justify-content: start;
}

.rtl ul#adminmenu a.wp-has-current-submenu::after,
.rtl ul#adminmenu > li.current > a.current::after {
border-right-color: transparent;
border-left-color: #fff;
}
</style>
<?php
}

require_once ABSPATH . 'wp-admin/admin-footer.php';
Loading