Conversation
4ed52e8 to
4ceaba3
Compare
9433dd9 to
feb49d9
Compare
Run the mysql-on-sqlite PHPUnit suite against Doltlite commit 0745bbab by building it from source and installing its shared library as the libsqlite3 resolved by PHP's pdo_sqlite. Keep three CI-only compatibility patches for rowid tables, schema SQL canonicalization, and logical journal modes, with a focused runtime check before the full PHPUnit run.
Remove Doltlite's persistent per-database lock file alongside the standard SQLite sidecars so file-based connection tests leave their temporary directories empty.
Member
Author
|
Closing this for now. We can reopen when needed. Doltlite compatibility with SQLite is pretty good and improving. If needed, it is viable to be used with this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runs the mysql-on-sqlite PHPUnit suite against Doltlite, pinned to
0745bbab. The full suite passes with 740 tests, 1,428,287 assertions, 15 skipped, 2 incomplete.The workflow builds Doltlite from source, installs it as the system
libsqlite3so PHP'spdo_sqliteresolves against it, verifies that Doltlite is active, and runs PHPUnit without filters. Installing the library replaces the earlierLD_PRELOADapproach, which loses topdo_sqlite'sDT_NEEDEDbinding onlibsqlite3.so.0.Three narrow, CI-only compatibility patches remain:
WITHOUT ROWID, while the driver still relies on rowid access for table recreation, limited UPDATE/DELETE rewrites, on-update triggers, zero-column result statements, and information-schema ordering.--comments from consuming the rest of a restoredCREATE TABLEstatement.File-based tests also remove Doltlite's persistent per-database lock file during cleanup, alongside standard SQLite sidecars.
Upstreaming the remaining Doltlite compatibility changes is a separate task.
Test plan
PHPUnit Tests (Doltlite)passes:740 tests, 1,428,287 assertions, 15 skipped, 2 incomplete.