Global Styles: Switch the revisions screen to the DataViews pickerActivity layout - #80856
Draft
jorgefilipecosta wants to merge 1 commit into
Conversation
jorgefilipecosta
force-pushed
the
update/73463-global-styles-revisions-picker-activity
branch
from
July 29, 2026 19:38
fd19054 to
1a29a93
Compare
jorgefilipecosta
force-pushed
the
update/73463-global-styles-revisions-picker-activity
branch
from
July 29, 2026 21:24
1a29a93 to
14e6e60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73463
The Global Styles revisions screen rendered its own timeline: a hand-rolled
Compositelistbox, custom dot/line CSS, and a local pagination component. This switches it toDataViewsPickerwith thepickerActivitylayout, the same component the post revisions timeline uses since #77333, and deletes the custom list and pagination code.The information architecture stays as it was. The date is the title field, the author avatar and name render under it, and the selected revision progressively discloses the changes summary plus the Apply / Reset to defaults button or the Active badge, through a description field that only renders content for the selected item. Selection is still driven by the
/revisions/:revisionId?route, so the canvas preview is untouched, and pagination remains server-side withview.pagedriving the query. The option labels ("Changes saved by %1$s on %2$s", "Unsaved changes by %s", "Reset the styles to the theme defaults") moved into the title field'sgetValue, which the picker uses as the option's accessible name, so labels are unchanged for screen readers and for the existing e2e coverage.The screen also gets a bounded height, scoped with
:has()in the Global Styles sidebar styles like the post revisions timeline does in the document sidebar, so the timeline scrolls internally and the pagination footer stays pinned to the bottom. This is not just cosmetic: when the picker is unbounded inside the sidebar scroller, focusing the listbox scrolls the sidebar mid-click and the first click on a revision is lost.Visible differences, all inherited from the shared layout: the selected/hover tint uses the design system token instead of the admin color at 4% opacity, the dot and date no longer turn blue on selection, and the pagination footer is the standard DataViews one.
Before
After
Compared with the post revisions timeline
The same layout as the post revisions timeline renders it in the document sidebar (#77333), side by side with this PR — same dates treatment, author rows, timeline, selection tint, and pagination footer:
Testing Instructions
npm run test:unit packages/global-styles-ui/src/screen-revisionsandnpm run test:e2e -- test/e2e/specs/site-editor/user-global-styles-revisions.spec.jspass.AI usage disclosure: implementation and description drafted with AI assistance and reviewed by me.