UI: Hook Popover into the wp compat overlay slot - #80278
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +11 B (0%) Total Size: 7.72 MB 📦 View Changed
|
|
Flaky tests detected in 49275b3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/29413767365
|
|
There was a conflict while trying to cherry-pick the commit to the wp/7.1 branch. Please resolve the conflict manually and create a PR to the wp/7.1 branch. PRs to wp/7.1 are similar to PRs to trunk, but you should base your PR on the wp/7.1 branch instead of trunk. |
* UI: Hook Popover into the wp compat overlay slot (#80278) * Popover: Use the wp compat overlay slot * Popover: Add changelog entry * Popover: Rename legacy Storybook import --- * UI: Keep the compat overlay slot accessible inside Modal (#80310) * UI: Keep compat overlay slot accessible in Modal * UI: Add compat overlay accessibility changelog * UI: Clarify compat overlay changelog wording * Modal: Add compat overlay integration test --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: aduth <aduth@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
|
Manual backport to 7.1 beta done in #80322 |
|
Removing the |
* UI: Hook Popover into the wp compat overlay slot (#80278) * Popover: Use the wp compat overlay slot * Popover: Add changelog entry * Popover: Rename legacy Storybook import --- * UI: Keep the compat overlay slot accessible inside Modal (#80310) * UI: Keep compat overlay slot accessible in Modal * UI: Add compat overlay accessibility changelog * UI: Clarify compat overlay changelog wording * Modal: Add compat overlay integration test --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: aduth <aduth@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Follow-up to #77851.
Supports the controlled Popover use in #80208.
What?
Defaults
@wordpress/uiPopover.Portalto the wp compat overlay slot when the host opts in.Popoverremains markeduse-with-cautionand is not added to the recommended-components allowlist.Why?
A controlled UI Popover can appear inside an
@wordpress/componentsModal or Popover. Without the compat slot, its portal can stack below the host overlay.This does not make arbitrary mixed overlay descendants compatible. Keeping Popover unrecommended preserves that caveat while allowing controlled uses to participate in the existing compatibility mechanism.
How?
Testing Instructions
npm run test:unit -- packages/ui/src/popover/test/index.test.tsx --runInBand.node_modules/.bin/tsc --build packages/ui/tsconfig.json.npm run storybook:dev.@wordpress/componentsoverlay.Testing Instructions for Keyboard
Screenshots or screencast
Not applicable; this changes overlay placement without an intended visual change.
AI Tools
Authored with Codex assistance.