Private APIs: Remove design system packages from packages using private APIs - #80215
Private APIs: Remove design system packages from packages using private APIs#80215aduth wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -5 B (0%) Total Size: 7.71 MB 📦 View Changed
|
| - Allow `@wordpress/global-styles-engine` to opt in to private APIs. ([#79104](https://github.com/WordPress/gutenberg/pull/79104)) | ||
| - Allow `@wordpress/global-styles-engine` to opt in to private APIs ([#79104](https://github.com/WordPress/gutenberg/pull/79104)). | ||
|
|
||
| ### Code Quality |
There was a problem hiding this comment.
I'd rather use the ### Deprecations header here. That's a better description, even if we're not literally doing a typical API deprecation. "Code Quality" are usually internal refactorings that are invisible to the consumer.
There was a problem hiding this comment.
I also wouldn't add the new entry under "Code Quality", but I would choose "Internal" instead
| '@wordpress/routes', | ||
| '@wordpress/storybook', | ||
| '@wordpress/sync', | ||
| '@wordpress/theme', |
There was a problem hiding this comment.
Actually, wait a moment — the theme package is still using private APIs at this time
|
Good catch @ciampo 🙏 I was unquestioningly catching up on my backlog task in #78958 (comment) and neglected to consider the partial revert that came later. Thanks for flagging that, and let's plan to revisit this once we can remove that compatibility layer. Glad to see that the tests caught it as well. |
What?
Updates
@wordpress/private-apisinternal list of packages using private APIs to reflect the fact that@wordpress/themeand@wordpress/uino longer use private APIs.Follow-up to: #78958 (comment)
Why?
This list should reflect the current reality of packages using private APIs.
Tracking issue for
@wordpress/uiremoving private APIs: #75319#78958 removed API locking from
@wordpress/theme.Timing-wise, this also pairs well with ongoing stabilization of the theme package , which was promoted to a stable package in #80049.
Testing Instructions
I suppose you could try to use the
lockorunlockmechanism with this package name and verify that it no longer allows you to lock or unlock.Use of AI Tools
No AI was used.