-
Notifications
You must be signed in to change notification settings - Fork 4.9k
UI Card: full bleed as header hero image & content cover #77856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7055932
Card: allow FullBleed bump against top border inside Header
simison 74781d5
Restore padding above header title when combined with full bleed image
simison 4c86943
Add 'full bleed hero only' story
simison 86a0b97
Implement cover "full bleed"
simison 6b1798b
Add PR to changelog
simison 6034a4b
Fix missing gap between content and header when header isn't first child
simison 57fed7a
Revert "Fix missing gap between content and header when header isn't …
simison 451deff
Update JSDoc to mention all possible interactions with other subcompo…
simison 21550a0
Remove superflous style
simison 32b2c54
Condence styles
simison 4c56075
Add examples for collapsable card
simison 40d4a97
Put back padding between full bleed and header title
simison c5021f0
Fix collapsable card
simison 42b69b2
Remove couple collapsable card stories
simison b8822a3
Update JSDocs about unsupported FullBleed in CollapsibleCard Header
simison 90aef37
Update packages/ui/CHANGELOG.md
simison fc2c6b7
Update JSDoc for FullBleed
simison a3d2945
Update comment in CSS
simison 1c0a1d2
Fix gap between text content and full bleed in "featured image" example
simison 96488fe
Use Stack via `render` for inter-sibling spacing in FullBleed stories
ciampo b833b09
Drop asymmetric `Header` + `FullBleed` gap rule
ciampo 2905e8d
Restore Header bullet in FullBleed JSDoc and document Stack pattern
ciampo ceb7e12
Rename Card FullBleed stories for clarity
ciampo 2da3944
Update stale references after FullBleed story renames and rule removal
ciampo b34df23
Move FullBleed CHANGELOG entry back under Unreleased
ciampo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.