-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Tabs: Simplify layout and prune redundant block supports #77646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
52eaca0
7ef5211
a1dcbc1
24cd3bf
4b9cda6
4570c8b
55e1b70
e15d6f3
88aac54
a5edbb1
9e3a086
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,6 @@ | ||
| .wp-block-tab-panel { | ||
| max-width: 100%; | ||
| flex-basis: 100%; | ||
| flex-grow: 1; | ||
| box-sizing: border-box; | ||
|
Comment on lines
-2
to
-5
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the layout of the Tab panels block has been changed from Flex to Flow, styles related to the flex layout are no longer necessary. |
||
|
|
||
| & > *:first-child { | ||
| margin-top: 0; | ||
| } | ||
| & > *:last-child { | ||
| margin-bottom: 0; | ||
| } | ||
|
Comment on lines
-7
to
-12
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As the tab panel uses a flow layout, these styles are not needed. |
||
|
|
||
| &[hidden], | ||
| &:empty { | ||
| display: none !important; | ||
| } | ||
| } | ||
|
|
||
| .wp-block-tab-panel.wp-block.has-background, | ||
| .wp-block-tab-panel:not(.wp-block).has-background { | ||
| padding: var(--wp--preset--spacing--30); | ||
| } | ||
|
Comment on lines
-20
to
-23
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this block supports padding, the default padding feels redundant. Most blocks should no longer have this style. |
||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.