Interactivity API: Move all utils inside utils.ts - #61721
Merged
Conversation
DAreRodz
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
reviewed
May 16, 2024
sirreal
left a comment
sirreal
left a comment
Member
There was a problem hiding this comment.
It's kind of weird to have the directory, some single-function modules, and the index module with a bunch of stuff. What if we flatten and make it all utils.ts?
Contributor
Author
Sure. Let's do that. |
This reverts commit 5f669c1.
DAreRodz
changed the title
utils.ts inside the utils folder.utils.ts
|
Size Change: +581 B (+0.03%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
cbravobernal
enabled auto-merge (squash)
May 16, 2024 15:25
DAreRodz
commented
May 16, 2024
| }, | ||
| transformIgnorePatterns: [ | ||
| '/node_modules/(?!(docker-compose|yaml)/)', | ||
| '/node_modules/(?!(docker-compose|yaml|preact|@preact|deepsignal)/)', |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
May 27, 2024
* Move utils file inside folder * Revert "Move utils file inside folder" This reverts commit 5f669c1. * Move all utils inside `utils.ts` * Fix utils tests and move them to TS Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Right now, utility functions live in different files and folders. This PR moves everything inside the
utils.tsfile, just to keep the code a bit more organized.