Truncate UTF-8 heavy fields when writing STATA#383
Open
FlipperPA wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
Apologies for the "git noise" from my previous contributions. I should've rebased! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #382
This truncates the very rare edge cases that exceed the byte limit, because of heavy UTF-8 usage. This path was chosen because using
strLin STATA would require a significant rewrite to re-count the byte map for the binary file.This will very, very rarely truncate the field, but provide the full row count, rather than silently dropping the entire row.