VMCluster/VMAlertmanager: reject serviceSpec.type override with useAsDefault - #2491
Open
mehrdadbn9 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follows up on #2487. As discussed in the issue, the default Service of
vmselect,vmstorageandvmalertmanageris intentionally headless (clusterIP: None) because it also exposes cluster-native / gossip ports. Because of that, combiningserviceSpec.useAsDefault: truewith an explicitspec.typesilently produces a service that is still headless - the user gets no error and no VIP, which is confusing.Per the maintainer's suggestion in #2487 (comment) (prohibit overriding the service type for these components when
useAsDefault: true), this PR makes the operator reject that combination with a clear error message instead of silently ignoring it.Changes
AdditionalServiceSpec.ValidateNoServiceTypeOverrideWithUseAsDefault(component)- new helper that rejects an explicitspec.typewhenuseAsDefaultis set.VMCluster.Validate()forvmselectandvmstorage.VMAlertmanager.Validate()forvmalertmanager.vminsertis intentionally left allowed: its default Service is not headless, so an explicit type override there works as expected.Users who need a different service type can still create a separate additional Service by setting
serviceSpec.useAsDefault: falsewith a distinctmetadata.name.Tests
Added unit test cases covering: reject for vmselect/vmstorage/vmalertmanager, allow when no explicit type is set, allow separate additional services, and allow type override for vminsert.
Feedback welcome - happy to adjust the error message wording or the scope if you'd rather also cover
vminsert.