Key the date scrubber caches on DateTimeFormat - #1906
Merged
Merged
Conversation
The window bound cache was keyed on the culture name, and the resolver cache on the culture itself, whose equality only compares the name and the compare and text info. Two cultures can share a name and still render dates differently: a CurrentCulture carrying Windows user overrides against CultureInfo.GetCultureInfo of the same name, or a clone whose DateTimeFormat was replaced and handed to ScrubInlineDateTimes. Whichever was measured first then supplied the min and max window lengths for the other, so rendered dates fell outside the probed lengths and silently stopped being scrubbed. Both caches now key on the DateTimeFormat instance, which is what the bounds are actually derived from.
This was referenced Sep 12, 2026
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window bound cache was keyed on the culture name, and the resolver cache on the culture itself, whose equality only compares the name and the compare and text info. Two cultures can share a name and still render dates differently: a CurrentCulture carrying Windows user overrides against CultureInfo.GetCultureInfo of the same name, or a clone whose DateTimeFormat was replaced and handed to ScrubInlineDateTimes.
Whichever was measured first then supplied the min and max window lengths for the other, so rendered dates fell outside the probed lengths and silently stopped being scrubbed.
Both caches now key on the DateTimeFormat instance, which is what the bounds are actually derived from.