Process: Drop capabilities when spawning processes - #2313
Open
ImSapphire wants to merge 1 commit into
Open
Conversation
Collaborator
|
could you give some simple steps for how to repro what this fixes? thanks. |
Author
|
Try launching any executable with bwrap under gamescope while gamescope has the CAP_SYS_NICE capability. bwrap will refuse to run if it has any capabilities set and setuid mode isn't enabled during build, or it doesn't have setuid: https://github.com/containers/bubblewrap/blob/1b80120ef26a28e065e67f89bfef873f13bdd317/bubblewrap.c#L889 |
bubblewrap will refuse to run if it is not setuid and has any capabilities set. It's also probably not a good idea to leak our caps to the child application anyway.
ImSapphire
force-pushed
the
sapphire/fix/drop-caps-on-proc-spawn
branch
from
August 11, 2026 23:29
ea5ef05 to
2bc44ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes launching bwrap'd applications.