Final pipeline - #9
Closed
yb175 wants to merge 1 commit into
Closed
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Node API now loads layered environment files, normalizes trace agent steps and tool-call telemetry, adds Redis-backed reset controls, improves investigation failure details, and handles fingerprinted incident formation results including skipped outcomes. ChangesNode API trace and incident control
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant TraceEndpoint as POST /api/traces
participant normalizeAgentSteps
participant RiskEngine
participant AdaptiveSampler
participant formationService.process
TraceEndpoint->>normalizeAgentSteps: normalize incoming steps
normalizeAgentSteps-->>TraceEndpoint: agentSteps and tool-call telemetry
TraceEndpoint->>RiskEngine: evaluate trace
RiskEngine-->>TraceEndpoint: risk outcome and labels
TraceEndpoint->>AdaptiveSampler: determine sampling result
AdaptiveSampler-->>TraceEndpoint: sampled
TraceEndpoint->>formationService.process: submit labels and fingerprint
formationService.process-->>TraceEndpoint: action and incidentId
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Finalizes the node-api ingestion pipeline with incident fingerprinting, step normalization, and an admin reset endpoint. Improves dedupe, telemetry accuracy, and failure reporting while hardening env setup.
New Features
generateFingerprintfrom@void-server/incident-fingerprint; respond with "skipped" when formation takes no action./api/admin/resetto wipe Postgres data and flush Redis/BullMQ queues usingioredis.tool_callsshape for forward compatibility.Bug Fixes
env.ts: load.envfrom multiple paths, set a local default forDATABASE_URL, normalize port to 5432, and defaultREDIS_URLtoredis://localhost:6379.tool_callsand aligningtool_call_countwith normalized steps./api/investigationsfailure responses by returning the worker error fromengineering_reportwhen available.Written for commit 9090d90. Summary will update on new commits.
Summary by CodeRabbit
New Features
Bug Fixes