Skip to content

use norm explicitly #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beckermr merged 8 commits into from
Feb 14, 2025
Merged

use norm explicitly #76

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df2079b
use norm explicitly
cvanelteren Feb 14, 2025
a456fc6
remove debug statement
cvanelteren Feb 14, 2025
0bcf5df
add second test
cvanelteren Feb 14, 2025
0c61966
edge case when norm is string
cvanelteren Feb 14, 2025
5a6181f
removed additional space
cvanelteren Feb 14, 2025
e146bf3
make test into img compare
cvanelteren Feb 14, 2025
dbcbbd2
updated warning message
cvanelteren Feb 14, 2025
a611e9f
remove debug statement
cvanelteren Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ultraplot/axes/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2296,6 +2296,9 @@ def _parse_cmap(
cmap_kw = cmap_kw or {}
norm_kw = norm_kw or {}
# If norm is given we use it to set vmin and vmax
if (vmin is not None or vmax is not None) and norm is not None:
print(vmin, vmax, norm)
Comment thread
beckermr marked this conversation as resolved.
Outdated
raise ValueError("If 'norm' is given, 'vmin' and 'vmax' must not be set.")
if isinstance(norm, mcolors.Normalize):
vmin = norm.vmin
vmax = norm.vmax
Expand Down
9 changes: 5 additions & 4 deletions ultraplot/tests/test_1dplots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ def test_triplot_variants(x, y, z, triangles, use_triangulation, use_datadict):
return fig


@pytest.mark.mpl_image_compare
def test_norm_not_modified():
"""
Ensure that norm is correctly passed to pcolor and related functions.
Expand All @@ -443,17 +444,17 @@ def test_norm_not_modified():
c = y
cmap = uplt.Colormap("viridis")
norm = uplt.Norm("linear", 0, 10)
fig, ax = uplt.subplots()
ax.scatter(x, y, c=c, cmap=cmap, norm=norm)
fig, (left, right) = uplt.subplots(ncols=2, share=0)
left.scatter(x, y, c=c, cmap=cmap, norm=norm)
assert norm.vmin == 0
assert norm.vmax == 10

arr = np.random.rand(20, 40) * 1000
xe = np.linspace(0, 1, num=40, endpoint=True)
ye = np.linspace(0, 1, num=20, endpoint=True)

fig, ax = uplt.subplots()
norm = uplt.Norm("linear", vmin=0, vmax=1)
ax.pcolor(xe, ye, arr, cmap="viridis", norm=norm)
right.pcolor(xe, ye, arr, cmap="viridis", norm=norm)
assert norm.vmin == 0
assert norm.vmax == 1
return fig