show correct number in badge - #2071
Closed
C-Otto wants to merge 1 commit into
Closed
Conversation
Closed
This was referenced Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2058
Please advice on how to clean this up, and add proper tests!
The actual badge number (which is shown on page reload) is defined in
ProjectsController#show. Similar code (duplicated?) is inContextController#show.When toggling an action as stated in #2058 the badge number is determined using
TodosController#determine_down_count. Of the 30 lines or so, only a SINGLE result is tested.