Relay configuration interface - #6721
Merged
Merged
Conversation
adriansmares
force-pushed
the
feature/relay-interface
branch
from
November 24, 2023 16:18
2ecb67d to
aab3efe
Compare
adriansmares
force-pushed
the
feature/relay-interface
branch
3 times, most recently
from
November 30, 2023 09:08
8da04c3 to
a844491
Compare
adriansmares
force-pushed
the
feature/relay-interface
branch
8 times, most recently
from
December 8, 2023 11:36
2d9a83a to
2def70c
Compare
This was referenced Dec 8, 2023
adriansmares
force-pushed
the
feature/relay-interface
branch
4 times, most recently
from
December 8, 2023 18:57
590bb2f to
7cfd7d8
Compare
adriansmares
force-pushed
the
feature/relay-interface
branch
from
December 11, 2023 11:29
7cfd7d8 to
7f9ba1f
Compare
johanstokking
approved these changes
Dec 14, 2023
johanstokking
left a comment
Member
There was a problem hiding this comment.
LGTM but can we expand the scope of #6728 at least to include a client, i.e. CLI? And file an issue for Console support?
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References #6728
Changes
CreatefromUpdate, as opposed to our usualSetmethods, in order to create semantic clarity.Testing
Local testing with Postman. A subsequent PR will add the associated CLI for this new service, along with extra unit testing.
No manual testing will be required for this PR - the CLI will be the good way to test this manually.
Regressions
The new settings message is binary compatible with the old parameter message, although two fields (the backoff and the default channel index) have had their format change (from
uint32toUInt32Value) - this is fine as this API and functionality were never released officially nor are the two fields extremely important for already registered relay-enabled devices.Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.