Skip to content

linear_programming: raise on simplex non-convergence#14607

Open
Kcstring wants to merge 1 commit intoTheAlgorithms:masterfrom
Kcstring:fix-simplex-maxiter-error
Open

linear_programming: raise on simplex non-convergence#14607
Kcstring wants to merge 1 commit intoTheAlgorithms:masterfrom
Kcstring:fix-simplex-maxiter-error

Conversation

@Kcstring
Copy link
Copy Markdown

Describe your change:

Fixes #14584

Tableau.run_simplex() now raises a descriptive ValueError when Tableau.maxiter is exhausted instead of silently returning {}. This lets callers distinguish a non-converged or cycling tableau from a real empty solution.

The doctest temporarily sets Tableau.maxiter = 0 to cover the non-convergence path deterministically.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Testing:

  • python3 -m pytest linear_programming/simplex.py
  • python3 -m ruff check linear_programming/simplex.py

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: run_simplex() returns empty dict {} on max iteration instead of raising an informative error

1 participant