added stack_using_two_queues.py by Samar-28 · Pull Request #10080 · TheAlgorithms/Python

Samar-28 · 2023-10-08T07:08:37Z

Describe your change:

"Fixes #9987".

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-08T07:08:42Z

@@ -0,0 +1,50 @@
+class Stack:
+    def __init__(self):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

algorithms-keeper · 2023-10-08T07:08:43Z

+    def __init__(self):
+        self.items = []
+
+    def push(self, item):


As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/stack_using_two_queues.py, please provide doctest for the function push

Please provide return type hint for the function: push. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: item

algorithms-keeper · 2023-10-08T07:08:43Z

+    def push(self, item):
+        self.items.append(item)
+
+    def pop(self):


As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/stack_using_two_queues.py, please provide doctest for the function pop

Please provide return type hint for the function: pop. If the function does not return a value, please provide the type hint as: def function() -> None:

algorithms-keeper · 2023-10-08T07:08:43Z

+        else:
+            return "Stack is empty"
+
+    def peek(self):


As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/stack_using_two_queues.py, please provide doctest for the function peek

Please provide return type hint for the function: peek. If the function does not return a value, please provide the type hint as: def function() -> None:

algorithms-keeper · 2023-10-08T07:08:43Z

+        else:
+            return "Stack is empty"
+
+    def is_empty(self):


As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/stack_using_two_queues.py, please provide doctest for the function is_empty

Please provide return type hint for the function: is_empty. If the function does not return a value, please provide the type hint as: def function() -> None:

algorithms-keeper · 2023-10-08T07:08:43Z

+    def is_empty(self):
+        return len(self.items) == 0
+
+    def size(self):


As there is no test file in this pull request nor any test function or class in the file data_structures/stacks/stack_using_two_queues.py, please provide doctest for the function size

Please provide return type hint for the function: size. If the function does not return a value, please provide the type hint as: def function() -> None:

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-10-08T07:19:21Z

+
+class StackUsingQueues:
+
+    def __init__(self):


Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

for more information, see https://pre-commit.ci

cclauss

We already have #10002 open.

cclauss · 2023-10-15T16:42:21Z

Fixed in data_structures/stacks/stack_using_two_queues.py

added stack_using_two_queues.py

8ebf863

algorithms-keeper Bot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Oct 8, 2023

algorithms-keeper Bot reviewed Oct 8, 2023

View reviewed changes

algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 8, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

494e92f

for more information, see https://pre-commit.ci

algorithms-keeper Bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 8, 2023

Update stack_using_two_queues.py

add19ec

algorithms-keeper Bot removed the require tests Tests [doctest/unittest/pytest] are required label Oct 8, 2023

algorithms-keeper Bot reviewed Oct 8, 2023

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

98bb070

for more information, see https://pre-commit.ci

algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 8, 2023

Update stack_using_two_queues.py

6ead57f

algorithms-keeper Bot removed require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass labels Oct 8, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks

d195328

for more information, see https://pre-commit.ci

algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 8, 2023

Samar-28 and others added 6 commits October 8, 2023 12:57

Update stack_using_two_queues.py

a04fcae

[pre-commit.ci] auto fixes from pre-commit.com hooks

1b3fba0

for more information, see https://pre-commit.ci

Update stack_using_two_queues.py

952b5a4

[pre-commit.ci] auto fixes from pre-commit.com hooks

4e6c600

for more information, see https://pre-commit.ci

Update stack_using_two_queues.py

3403da7

[pre-commit.ci] auto fixes from pre-commit.com hooks

57c235a

for more information, see https://pre-commit.ci

cclauss reviewed Oct 8, 2023

View reviewed changes

cclauss self-assigned this Oct 8, 2023

cclauss closed this Oct 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

added stack_using_two_queues.py#10080

added stack_using_two_queues.py#10080
Samar-28 wants to merge 12 commits intoTheAlgorithms:masterfrom
Samar-28:patch-1

Samar-28 commented Oct 8, 2023

Uh oh!

algorithms-keeper Bot left a comment

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Uh oh!

algorithms-keeper Bot left a comment

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Uh oh!

cclauss left a comment

Uh oh!

cclauss commented Oct 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Samar-28 commented Oct 8, 2023

Describe your change:

Checklist:

Uh oh!

algorithms-keeper Bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper Bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper Bot Oct 8, 2023

Choose a reason for hiding this comment

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss commented Oct 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants