temp(paykit): workaround for stripe SDK checkout/payment_intent ID in… - #430
Conversation
|
Review changes with Changed Files |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 33 minutes and 54 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR extends the PayKit Stripe payment provider to reliably handle Stripe Checkout Session IDs across payment operations. It introduces checkout-session type definitions, refactors the runtime client factory to preserve the provider instance, and implements comprehensive session-aware helpers for status mapping, customer extraction, and payment operations. ChangesStripe Checkout Session Support
Sequence DiagramssequenceDiagram
participant PaykitStripePaymentProvider
participant withStripeCheckoutSessionRetrieve
participant stripeCheckoutSessions
participant StripePaymentsAPI
PaykitStripePaymentProvider->>withStripeCheckoutSessionRetrieve: payments.retrieve(cs_id)
withStripeCheckoutSessionRetrieve->>stripeCheckoutSessions: retrieve(cs_id, expand: payment_intent)
stripeCheckoutSessions->>StripePaymentsAPI: checkout_sessions.retrieve(cs_id)
StripePaymentsAPI-->>stripeCheckoutSessions: session with payment_intent expanded
stripeCheckoutSessions-->>withStripeCheckoutSessionRetrieve: PaykitStripeCheckoutSession
withStripeCheckoutSessionRetrieve->>withStripeCheckoutSessionRetrieve: toPaykitPaymentFromStripeCheckoutSession
withStripeCheckoutSessionRetrieve-->>PaykitStripePaymentProvider: PaykitPayment
flowchart TD
getOpId["getStripeOperationPaymentId(id, data)"]
isCS{"id is checkout session ID?"}
retrieve["retrieve session with payment_intent"]
extract["extract payment_intent.id"]
fallback["use id as PaymentIntent ID"]
return["return operation PaymentIntent ID"]
getOpId --> isCS
isCS -->|yes| retrieve
isCS -->|no| fallback
retrieve --> extract
extract --> return
fallback --> return
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds a workaround for a PayKit Stripe SDK inconsistency where
Confidence Score: 4/5Safe to merge as a workaround; the checkout-session cancel branching correctly avoids the previously broken expire-on-complete behavior, and all new paths are covered by unit tests. The new cancelOrExpireCheckoutSessionPayment logic is correct and well-tested. The duplicated isRecord/isPaymentAmount and the plain Error throw are non-blocking style issues that do not affect correctness on the changed paths. apps/medusa-be/src/modules/payment-paykit/services/stripe.ts — the duplicated utility functions and plain Error throw are worth a second look. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[cancelPayment / deletePayment] --> B[cancelOrExpirePayment]
B --> C{Is cs_ ID AND stripeCheckoutSessions?}
C -- No --> D[getStripeOperationPaymentId]
D --> E[client.payments.cancel]
C -- Yes --> F[cancelOrExpireCheckoutSessionPayment]
F --> G[stripeCheckoutSessions.retrieve]
G --> H{session found?}
H -- No --> I[return undefined, fall through]
I --> D
H -- Yes --> J{session.status === open?}
J -- Yes --> K{expire available?}
K -- Yes --> L[stripeCheckoutSessions.expire]
L --> M[return expired session data]
K -- No --> N[return data unchanged]
J -- No --> O[map session to PaykitPayment]
O --> P{status === requires_capture?}
P -- Yes --> Q[client.payments.cancel with PI id]
Q --> R[return canceled PI data preserving cs_ id]
P -- No --> S[return current session state]
S --> T[may include status: succeeded for paid sessions]
Reviews (3): Last reviewed commit: "temp(paykit): added regression tests" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.github.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/medusa-be/src/modules/payment-paykit/services/stripe.ts`:
- Around line 214-243: withStripeCheckoutSessionRetrieve: wrap the call to
client.payments.retrieve(id) in a try/catch and, when the id matches
isStripeCheckoutSessionId(id) and the Stripe SDK throws the "wrong_resource" /
wrong-resource-type error (use the error shape from `@paykit-sdk/stripe`), fall
back to client.stripeCheckoutSessions.retrieve(id) as currently done;
cancelOrExpirePayment: before calling
stripeCheckoutSessions.expire(providerPaymentId) (in cancelOrExpirePayment),
retrieve the session state and only call expire when the session is in an
expirable state (e.g., "open"); add tests for non-open/cancelled/paid sessions
to ensure no expire is attempted. getCaptureAmount/getExplicitCaptureAmount:
replace blind casts from Reflect.get(...) / input.data?.amount with runtime
numeric validation similar to the base provider's isPaymentAmount check
(validate type and range) before normalising and returning the amount.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 12387b11-b79c-446e-8d73-c2e28e7e77fa
📒 Files selected for processing (5)
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.tsapps/medusa-be/src/modules/payment-paykit/runtime.tsapps/medusa-be/src/modules/payment-paykit/services/stripe.tsapps/medusa-be/src/modules/payment-paykit/types/index.ts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Greptile Review
- GitHub Check: main
- GitHub Check: Kilo Code Review
🧰 Additional context used
📓 Path-based instructions (9)
apps/medusa-be/src/modules/**/*
📄 CodeRabbit inference engine (CLAUDE.md)
Place custom Medusa modules under apps/medusa-be/src/modules
Module directories use hyphens (
my-module/), but module keys in config use underscores (my_module)
Files:
apps/medusa-be/src/modules/payment-paykit/types/index.tsapps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.tsapps/medusa-be/src/modules/payment-paykit/runtime.tsapps/medusa-be/src/modules/payment-paykit/services/stripe.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Import UI components using the pattern
import { ComponentName } from '@libs/ui/atoms/component-name'or'@libs/ui/molecules/component-name'
Files:
apps/medusa-be/src/modules/payment-paykit/types/index.tsapps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.tsapps/medusa-be/src/modules/payment-paykit/runtime.tsapps/medusa-be/src/modules/payment-paykit/services/stripe.ts
apps/medusa-be/src/{api,modules,workflows,admin,subscribers,jobs}/**
📄 CodeRabbit inference engine (AGENTS.md)
In Medusa backend applications, organize custom code using the directory structure: api/, modules/, workflows/, admin/, subscribers/, jobs/
Files:
apps/medusa-be/src/modules/payment-paykit/types/index.tsapps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.tsapps/medusa-be/src/modules/payment-paykit/runtime.tsapps/medusa-be/src/modules/payment-paykit/services/stripe.ts
apps/medusa-be/**/*.{ts,tsx}
📄 CodeRabbit inference engine (apps/medusa-be/CLAUDE.md)
apps/medusa-be/**/*.{ts,tsx}: Runnpx tsc --noEmitfor typechecking before committing
Always use braces around conditional blocks, even for single statements; Biome will expand them
Declare one variable perconst/letstatement, not multiple on one line
Use nullish coalescing operator (??) instead of logical OR (||) for default values
Do not use non-null assertions (!); use type guards or validation instead
Annotate type asunknownwhen accessing dynamic object properties before applying type guards
Use comments only to explain 'why', never 'what'; self-document code with clear naming
Extract pure functions to separate files for testability without runtime dependencies
UseModules.*andContainerRegistrationKeys.*constants instead of hardcoding module/key strings
Do not use non-null assertions in TypeScript code; validate or use type guards instead
Validate data before type casting; never useas Typewithout prior validation
Files:
apps/medusa-be/src/modules/payment-paykit/types/index.tsapps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.tsapps/medusa-be/src/modules/payment-paykit/runtime.tsapps/medusa-be/src/modules/payment-paykit/services/stripe.ts
apps/medusa-be/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (apps/medusa-be/CLAUDE.md)
Run
bunx biome check --write .to lint and auto-format code
Files:
apps/medusa-be/src/modules/payment-paykit/types/index.tsapps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.tsapps/medusa-be/src/modules/payment-paykit/runtime.tsapps/medusa-be/src/modules/payment-paykit/services/stripe.ts
apps/medusa-be/src/**/*.ts
📄 CodeRabbit inference engine (apps/medusa-be/CLAUDE.md)
apps/medusa-be/src/**/*.ts: Useconstand explicit typing withdbService.sqlRaw<Type>()for SQL query results
Resolve logger usingcontainer.resolve<Logger>(ContainerRegistrationKeys.LOGGER)
Resolve Query usingcontainer.resolve<Query>(ContainerRegistrationKeys.QUERY)
UseModules.LOCKING(notModules.LOCK) to resolve locking services
UseModules.CACHING(notModules.CACHE) to resolve caching services
ThrowMedusaErrorwith appropriate type and message for error responses
UseMedusaError.Types.INVALID_DATAfor 400 validation errors
UseMedusaError.Types.NOT_FOUNDfor 404 errors
UseMedusaError.Types.UNAUTHORIZEDfor 401 authentication errors
UseMedusaError.Types.NOT_ALLOWEDfor 400 permission errors
UseMedusaError.Types.DUPLICATE_ERRORfor 422 duplicate entry errors
UseMedusaError.Types.CONFLICTfor 409 conflict errors
Use caching module'scomputeKey()to generate stable cache keys from filters and pagination
Use caching module'sget()with type assertion for cache retrieval
Use caching module'sset()with TTL and tags for cache storage and bulk invalidation
Use caching module'sclear()with tags to bulk-invalidate related cache entries
Always use Redis for caching in multi-container deployments instead of local variables
Batch operations usingCHUNK_SIZEconstant instead of unbounded loops
Files:
apps/medusa-be/src/modules/payment-paykit/types/index.tsapps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.tsapps/medusa-be/src/modules/payment-paykit/runtime.tsapps/medusa-be/src/modules/payment-paykit/services/stripe.ts
apps/medusa-be/src/modules/**/*.ts
📄 CodeRabbit inference engine (apps/medusa-be/CLAUDE.md)
Modules use isolated containers; Query/Link unavailable during service initialization, defer to
onApplicationStart
Files:
apps/medusa-be/src/modules/payment-paykit/types/index.tsapps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.tsapps/medusa-be/src/modules/payment-paykit/runtime.tsapps/medusa-be/src/modules/payment-paykit/services/stripe.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use Vitest for running tests in backend and UI library projects
Files:
apps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
apps/medusa-be/src/modules/*/__tests__/*.spec.ts
📄 CodeRabbit inference engine (apps/medusa-be/CLAUDE.md)
apps/medusa-be/src/modules/*/__tests__/*.spec.ts: UsemoduleIntegrationTestRunner()for module tests with real DB instead of mocking MedusaService methods
Mock loaders in tests usingvi.mock()to prevent actual initialization during testing
Wrap missing dependency resolution in try/catch in integration tests; Awilix throws even with nullish coalescing
Files:
apps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
🧠 Learnings (18)
📚 Learning: 2026-04-29T15:44:04.609Z
Learnt from: KaiUweCZE
Repo: TechsioCZ/new-engine PR: 378
File: libs/storefront-data/package.json:285-286
Timestamp: 2026-04-29T15:44:04.609Z
Learning: In `libs/storefront-data/package.json`, `medusajs/js-sdk` and `medusajs/types` are intentionally pinned to an exact version in `devDependencies` (e.g., `"2.14.1"`). This is because the package generates TypeScript declaration files against the Medusa SDK/types, and a previous deploy failure was caused by different Medusa type versions being resolved in the build graph. The `peerDependencies` range remains broad (e.g., `>=2.12.0`) for consumers, while exact `devDependencies` pins ensure reproducible declaration generation. Do not flag these exact pins as inconsistencies.
Applied to files:
apps/medusa-be/src/modules/payment-paykit/types/index.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/tests/unit/**/*.unit.spec.ts : Use factory functions like `createMockEntity(overrides)` for test data generation
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/tests/unit/**/*.unit.spec.ts : Do not test mocked methods; test real behavior instead
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/src/modules/*/__tests__/*.spec.ts : Mock loaders in tests using `vi.mock()` to prevent actual initialization during testing
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/tests/unit/**/*.unit.spec.ts : Clear mocks with `mockFn.mockReset()` instead of `vi.clearAllMocks()` for `mockResolvedValueOnce` chains
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/src/modules/*/__tests__/*.spec.ts : Use `moduleIntegrationTestRunner()` for module tests with real DB instead of mocking MedusaService methods
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/tests/unit/**/*.unit.spec.ts : Focus unit tests on critical paths: validation, money calculations, and core business logic
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-21T11:46:40.903Z
Learnt from: redeyecz
Repo: TechsioCZ/new-engine PR: 323
File: apps/medusa-be/integration-tests/http/promotions-custom-rules.spec.ts:0-0
Timestamp: 2026-05-21T11:46:40.903Z
Learning: In `apps/medusa-be/integration-tests/http/promotions-custom-rules.spec.ts`, the test intentionally uses a custom `requestJson`/`createClient`/`fetch`-based HTTP harness (running against a full Docker stack) instead of `medusaIntegrationTestRunner()`. This is a deliberate decision because `medusaIntegrationTestRunner()` had issues with publishable-key resolution in the monorepo due to package-hoisting caveats. Do not flag the absence of `medusaIntegrationTestRunner()` in this file; it is marked for future refactoring when the monorepo/hoisting issue is resolved.
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/integration-tests/http/**/*.spec.ts : Use `headers: { 'x-publishable-api-key': pak.token }` for store auth in integration tests
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/src/modules/*/__tests__/*.spec.ts : Wrap missing dependency resolution in try/catch in integration tests; Awilix throws even with nullish coalescing
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/tests/unit/**/*.unit.spec.ts : Skip unit tests for: getters, static arrays, trivial transforms, constants, and pass-through methods
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/helpers.tsapps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/integration-tests/http/**/*.spec.ts : Write HTTP integration tests for: business logic routes, security-critical middleware, multi-step DB ops
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/tests/unit/jobs/**/*.spec.ts : Place job tests in `tests/unit/jobs/` not in `src/jobs/__tests__/` to avoid Medusa loading them at runtime
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/integration-tests/http/**/*.spec.ts : Use `medusaIntegrationTestRunner()` for HTTP integration tests with `api.get()`, `api.post()`, `api.delete()`
Applied to files:
apps/medusa-be/src/modules/payment-paykit/__tests__/stripe.unit.spec.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/src/modules/**/provider.ts : Use provider containers for extending existing modules (payment, fulfillment) with dependencies declared in `medusa-config.ts`
Applied to files:
apps/medusa-be/src/modules/payment-paykit/runtime.tsapps/medusa-be/src/modules/payment-paykit/services/stripe.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/src/modules/**/client.ts : Separate HTTP client logic from orchestration; use dedicated class for pure HTTP operations
Applied to files:
apps/medusa-be/src/modules/payment-paykit/runtime.ts
📚 Learning: 2026-05-07T19:18:05.075Z
Learnt from: redeyecz
Repo: TechsioCZ/new-engine PR: 390
File: apps/medusa-be/src/api/admin/packeta-labels/route.ts:121-121
Timestamp: 2026-05-07T19:18:05.075Z
Learning: In `apps/medusa-be`, the hard-coded fulfillment provider ID string (e.g. `"packeta_packeta"`) is intentionally kept inline for now, consistent with the PPL implementation pattern. Extracting these into shared constants (e.g. `PACKETA_FULFILLMENT_PROVIDER_ID`) is deferred to a future refactor pass when more providers are added. Do not flag this as an issue in code reviews.
Applied to files:
apps/medusa-be/src/modules/payment-paykit/runtime.ts
📚 Learning: 2026-05-11T23:01:30.923Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-05-11T23:01:30.923Z
Learning: Applies to apps/medusa-be/**/*.{ts,tsx} : Use `Modules.*` and `ContainerRegistrationKeys.*` constants instead of hardcoding module/key strings
Applied to files:
apps/medusa-be/src/modules/payment-paykit/runtime.ts
🔇 Additional comments (2)
apps/medusa-be/src/modules/payment-paykit/services/stripe.ts (2)
261-276: ⚡ Quick winrefactor(stripe): narrow dynamic capture amounts before casting.
These helpers cast dynamic values straight to
RefundPaymentInput["amount"], so malformed persisted data reaches amount normalisation without a useful validation error. Read the property asunknown, validate it, then narrow.[ suggest_essential_refactor ]
As per coding guidelines, "Annotate type as
unknownwhen accessing dynamic object properties before applying type guards" and "Validate data before type casting; never useas Typewithout prior validation".
488-511: ⚡ Quick winfix(stripe): guard
stripeCheckoutSessions.expire()sopayments.cancel()fallback still works.In
cancelOrExpirePayment(), expiring everycs_*id can cause Stripe to throw when the Checkout Session is already completed/expired/cancelled; because this block returns early, the method never reaches theclient.payments.cancel()fallback. Wrapclient.stripeCheckoutSessions.expire(providerPaymentId)in atry/catchand fall back topayments.cancel()only for the “session not open/invalid state” error case; otherwise rethrow, using the repo’s existing error predicate/helper if one exists.
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 participant
…consistency
Summary by CodeRabbit
New Features
Tests