fix(storefront-data): align medusa build-time dependencies - #378
Merged
Conversation
|
Review changes with |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughdevDependencies in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Blacksmith Account SuspendedThis Blacksmith account requires additional verification. Jobs targeting Blacksmith runners will not be picked up and will remain queued until they timeout. Please contact Blacksmith Support for assistance. |
![coderabbitai[bot]](https://avatars.github.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@libs/storefront-data/package.json`:
- Around line 285-286: The devDependencies currently pin `@medusajs/js-sdk` and
`@medusajs/types` to exact 2.14.1 which is inconsistent with peerDependencies and
the rest of devDependencies; update the entries in devDependencies to use caret
ranges (e.g., change "@medusajs/js-sdk": "2.14.1" and "@medusajs/types":
"2.14.1" to "@medusajs/js-sdk": "^2.14.1" and "@medusajs/types": "^2.14.1") or
run pnpm add -D `@medusajs/js-sdk`@^2.14.1 `@medusajs/types`@^2.14.1 to apply the
change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7f48b954-1410-4e59-af17-69606b3427dc
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
libs/storefront-data/package.json
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: main
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
Use pnpm CLI to add dependencies; never edit package.json directly
Files:
libs/storefront-data/package.json
🧠 Learnings (6)
📚 Learning: 2026-04-13T12:34:56.405Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T12:34:56.405Z
Learning: Applies to **/*.{test,spec}.{ts,tsx} : Use Vitest for running tests in backend and UI library projects
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-13T12:34:56.405Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T12:34:56.405Z
Learning: Applies to apps/medusa-fe/**/*.{ts,tsx,js,jsx} : Use Modern.js from Bytedance as the primary frontend framework, with Next.js 15+ as an alternative only when necessary
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/src/**/__tests__/**/*.spec.ts : Mock loaders using jest.mock() with __esModule: true and jest.fn() default export
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/src/**/__tests__/**/*.unit.spec.ts : Use jest.useFakeTimers() with jest.advanceTimersByTimeAsync() and jest.setSystemTime() for deterministic time-dependent testing
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/src/admin/**/*.{ts,tsx} : Import admin environment variables using import.meta.env.VITE_* and .DEV, .PROD suffixes
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-02-05T14:43:17.404Z
Learnt from: KaiUweCZE
Repo: NMIT-WR/new-engine PR: 324
File: apps/medusa-be/package.json:0-0
Timestamp: 2026-02-05T14:43:17.404Z
Learning: Validate and enforce React 19 compatibility across monorepo workspaces. Since Medusa UI supports React 19 via root package.json overrides and Medusa Cloud prerequisites show React 19 overrides for npm workspaces, ensure workspace root and all relevant package.json files align with React 19 (18+ requirement is satisfied). When reviewing, verify that overrides exist in the root package.json and that dependent packages in apps or packages directories declare React 19 (or compatible) in their peerDependencies or dependencies as appropriate for workspace usage.
Applied to files:
libs/storefront-data/package.json
🔇 Additional comments (1)
libs/storefront-data/package.json (1)
284-286:⚠️ Potential issue | 🔴 CriticalPackage.json edited directly, violating repository guidelines.
The dependencies were added by manually editing
package.json. As per coding guidelines, you must use the pnpm CLI to add dependencies:pnpm add -D `@medusajs/js-sdk`@2.14.1 `@medusajs/types`@2.14.1This ensures that
pnpm-lock.yamlis properly updated and dependency resolution is handled correctly. Please revert these manual changes and use the pnpm CLI instead.As per coding guidelines: Use pnpm CLI to add dependencies; never edit package.json directly.
⛔ Skipped due to learnings
Learnt from: CR Repo: TechsioCZ/new-engine PR: 0 File: AGENTS.md:0-0 Timestamp: 2026-04-13T12:34:56.405Z Learning: Always use CLI commands to install packages with pnpm rather than directly editing package.jsonLearnt from: CR Repo: TechsioCZ/new-engine PR: 0 File: AGENTS.md:0-0 Timestamp: 2026-04-13T12:34:56.405Z Learning: Applies to **/*.{test,spec}.{ts,tsx} : Use Vitest for running tests in backend and UI library projectsLearnt from: CR Repo: TechsioCZ/new-engine PR: 0 File: AGENTS.md:0-0 Timestamp: 2026-04-13T12:34:56.405Z Learning: Applies to apps/medusa-fe/**/*.{ts,tsx,js,jsx} : Use Modern.js from Bytedance as the primary frontend framework, with Next.js 15+ as an alternative only when necessary
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
libs/storefront-data/package.json (1)
275-287: 🧹 Nitpick | 🔵 TrivialConsider reverting
@medusajsMedusa devDependencies to exact pins for declaration generation consistency.The learning notes indicate that
@medusajs/js-sdkand@medusajs/typeswere intentionally pinned to exact versions (2.14.1) indevDependenciesto ensure reproducible TypeScript declaration generation and prevent the type version mismatches that previously caused deploy failures.This PR changes both to caret ranges (
^2.14.1). While your CI is well-protected bypnpm install --frozen-lockfileacross all workflows (preventing drift during builds), the caret ranges inpackage.jsonitself weaken the original design principle. If the lockfile is regenerated or if local development installs without the frozen-lockfile flag, versions could drift to2.15.xor later, reintroducing the declaration mismatch risk.To align with the documented design intent, consider reverting to exact pins:
"devDependencies": { - "@medusajs/js-sdk": "^2.14.1", - "@medusajs/types": "^2.14.1" + "@medusajs/js-sdk": "2.14.1", + "@medusajs/types": "2.14.1"Apply via:
pnpm add -D@medusajs/js-sdk@2.14.1@medusajs/types@2.14.1🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@libs/storefront-data/package.json` around lines 275 - 287, Revert the two Medusa devDependency ranges back to exact pins: change "@medusajs/js-sdk" and "@medusajs/types" from "^2.14.1" to "2.14.1" in package.json (devDependencies) and update the lockfile by running the package manager (e.g., pnpm add -D `@medusajs/js-sdk`@2.14.1 `@medusajs/types`@2.14.1) so TypeScript declaration generation remains reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@libs/storefront-data/package.json`:
- Around line 275-287: Revert the two Medusa devDependency ranges back to exact
pins: change "@medusajs/js-sdk" and "@medusajs/types" from "^2.14.1" to "2.14.1"
in package.json (devDependencies) and update the lockfile by running the package
manager (e.g., pnpm add -D `@medusajs/js-sdk`@2.14.1 `@medusajs/types`@2.14.1) so
TypeScript declaration generation remains reproducible.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 2e7bc735-66a2-484f-8b98-257b30580cf2
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
libs/storefront-data/package.json
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: main
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (1)
**/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
Use pnpm CLI to add dependencies; never edit package.json directly
Files:
libs/storefront-data/package.json
🧠 Learnings (20)
📓 Common learnings
Learnt from: KaiUweCZE
Repo: TechsioCZ/new-engine PR: 378
File: libs/storefront-data/package.json:285-286
Timestamp: 2026-04-29T15:44:01.106Z
Learning: In `libs/storefront-data/package.json`, `medusajs/js-sdk` and `medusajs/types` are intentionally pinned to an exact version in `devDependencies` (e.g., `"2.14.1"`). This is because the package generates TypeScript declaration files against the Medusa SDK/types, and a previous deploy failure was caused by different Medusa type versions being resolved in the build graph. The `peerDependencies` range remains broad (e.g., `>=2.12.0`) for consumers, while exact `devDependencies` pins ensure reproducible declaration generation. Do not flag these exact pins as inconsistencies.
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: libs/storefront-data/AGENTS.md:0-0
Timestamp: 2026-02-24T09:20:15.382Z
Learning: Applies to libs/storefront-data/**/*.{ts,tsx} : Use proper generics instead of `any` type in TypeScript
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: libs/storefront-data/AGENTS.md:0-0
Timestamp: 2026-02-24T09:20:15.382Z
Learning: Applies to libs/storefront-data/**/*.{ts,tsx,js,jsx} : Import from source, not from `./dist/` paths
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T12:34:56.405Z
Learning: Applies to apps/medusa-fe/**/*.{ts,tsx,js,jsx} : Use Modern.js from Bytedance as the primary frontend framework, with Next.js 15+ as an alternative only when necessary
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T12:34:56.405Z
Learning: Applies to **/*.{test,spec}.{ts,tsx} : Use Vitest for running tests in backend and UI library projects
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: libs/storefront-data/AGENTS.md:0-0
Timestamp: 2026-02-24T09:20:15.382Z
Learning: Applies to libs/storefront-data/**/*.{ts,tsx,js,jsx} : Use `createQueryKey()` utility instead of hardcoding query keys
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: libs/storefront-data/AGENTS.md:0-0
Timestamp: 2026-02-24T09:20:15.382Z
Learning: Applies to libs/storefront-data/**/*.{ts,tsx,js,jsx} : Do not mix server and client code in the same file
Learnt from: BleedingDev
Repo: TechsioCZ/new-engine PR: 351
File: libs/storefront-data/src/medusa/cart-flow.ts:147-149
Timestamp: 2026-03-16T19:29:52.752Z
Learning: In `libs/storefront-data/src/medusa/cart-flow.ts`, `UseMedusaCartInput` intentionally keeps `autoCreate` and `autoUpdateRegion` as pass-through fields (not omitted). The regression test `passes cart query input through to low-level hooks for region auto-create flows` explicitly depends on callers being able to opt into those behaviors. Do not suggest omitting or hard-coding these fields to `false`.
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/src/admin/**/*.{ts,tsx} : Import admin environment variables using import.meta.env.VITE_* and .DEV, .PROD suffixes
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: libs/storefront-data/AGENTS.md:0-0
Timestamp: 2026-02-24T09:20:15.382Z
Learning: Applies to libs/storefront-data/**/index.ts : Do not create barrel files with `index.ts` re-exports
📚 Learning: 2026-04-29T15:44:01.106Z
Learnt from: KaiUweCZE
Repo: TechsioCZ/new-engine PR: 378
File: libs/storefront-data/package.json:285-286
Timestamp: 2026-04-29T15:44:01.106Z
Learning: In `libs/storefront-data/package.json`, `medusajs/js-sdk` and `medusajs/types` are intentionally pinned to an exact version in `devDependencies` (e.g., `"2.14.1"`). This is because the package generates TypeScript declaration files against the Medusa SDK/types, and a previous deploy failure was caused by different Medusa type versions being resolved in the build graph. The `peerDependencies` range remains broad (e.g., `>=2.12.0`) for consumers, while exact `devDependencies` pins ensure reproducible declaration generation. Do not flag these exact pins as inconsistencies.
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/**/*.{ts,tsx} : Do not use non-null assertion operator (!) in TypeScript code
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/**/medusa-config.ts : Cross-module provider dependencies must declare 'dependencies' array in module config for injection into provider container
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-02-25T14:55:57.852Z
Learnt from: redeyecz
Repo: TechsioCZ/new-engine PR: 335
File: docker/development/medusa-be/Dockerfile:24-24
Timestamp: 2026-02-25T14:55:57.852Z
Learning: In docker/development/medusa-be/Dockerfile, the commented-out CMD line in the dev stage (`#CMD ["sh", "-c", "pnpm --filter medusa-be migrate && pnpm --filter medusa-be entrypoint && pnpm --filter medusa-be dev"]`) is intentionally kept for testing purposes and should not be removed.
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/**/*.{ts,tsx,js,jsx} : Declare one variable per const/let statement; do not use multiple declarations on one line
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/**/medusa-config.ts : Conditional module loading must be evaluated at BUILD time via environment variables, not runtime
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/src/**/*.ts : Use CACHING module's computeKey() for stable hash generation of cache keys
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/**/*.{ts,tsx} : Use Modules.* and ContainerRegistrationKeys.* constants instead of hardcoding strings for container resolution
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-13T12:34:56.405Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T12:34:56.405Z
Learning: Applies to apps/medusa-fe/**/*.{ts,tsx,js,jsx} : Use Modern.js from Bytedance as the primary frontend framework, with Next.js 15+ as an alternative only when necessary
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-16T08:11:15.980Z
Learnt from: KaiUweCZE
Repo: TechsioCZ/new-engine PR: 352
File: apps/n1/src/app/pokladna/_components/checkout-review.tsx:4-5
Timestamp: 2026-04-16T08:11:15.980Z
Learning: In `apps/n1` (TechsioCZ/new-engine), UI components must be imported via the real package entrypoint `techsio/ui-kit/atoms/<component>` and `techsio/ui-kit/molecules/<component>`. The legacy alias `ui/atoms/*` / `ui/molecules/*` has been removed from `apps/n1/tsconfig.json`. Do NOT flag `techsio/ui-kit/*` imports in `apps/n1` as incorrect; they are the mandated pattern. `libs/ui/package.json` declares the package name as `techsio/ui-kit` and `apps/n1/package.json` depends on it.
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/**/*.{ts,tsx,js,jsx} : Write comments explaining why code exists, not what it does; rely on self-documenting code with clear naming
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-03-26T09:04:05.641Z
Learnt from: KaiUweCZE
Repo: TechsioCZ/new-engine PR: 358
File: libs/ui/src/molecules/radio-card.tsx:337-401
Timestamp: 2026-03-26T09:04:05.641Z
Learning: In libs/ui (TechsioCZ/new-engine), compound components (e.g. Select, TreeView, RadioCard in libs/ui/src/molecules/) consistently use a plain exported function with static sub-components attached directly (e.g. `Select.Label = ...`, `Select.displayName = "Select"`). They do NOT use `Object.assign` or a typed compound-component interface. TypeScript declaration emit passes with this pattern; do not flag it as a type error in future reviews.
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/**/*.{ts,tsx,js,jsx} : Use nullish coalescing operator (??) instead of logical OR (||) for null/undefined defaults
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:32.911Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/zane-operator/AGENTS.md:0-0
Timestamp: 2026-04-27T14:21:32.911Z
Learning: Applies to apps/zane-operator/{apps/zane-operator/src/**/*.ts,docker/development/postgres/*.sh} : Do not broaden privileges to 'make it work'; if broad prod access is requested, gate it behind explicit opt-in flags
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-13T12:34:56.405Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-04-13T12:34:56.405Z
Learning: Applies to **/*.{test,spec}.{ts,tsx} : Use Vitest for running tests in backend and UI library projects
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/src/admin/**/*.{ts,tsx} : Import admin environment variables using import.meta.env.VITE_* and .DEV, .PROD suffixes
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/src/**/__tests__/**/*.spec.ts : Mock loaders using jest.mock() with __esModule: true and jest.fn() default export
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-04-27T14:21:10.765Z
Learnt from: CR
Repo: TechsioCZ/new-engine PR: 0
File: apps/medusa-be/CLAUDE.md:0-0
Timestamp: 2026-04-27T14:21:10.765Z
Learning: Applies to apps/medusa-be/src/**/__tests__/**/*.unit.spec.ts : Use jest.useFakeTimers() with jest.advanceTimersByTimeAsync() and jest.setSystemTime() for deterministic time-dependent testing
Applied to files:
libs/storefront-data/package.json
📚 Learning: 2026-02-05T14:43:17.404Z
Learnt from: KaiUweCZE
Repo: NMIT-WR/new-engine PR: 324
File: apps/medusa-be/package.json:0-0
Timestamp: 2026-02-05T14:43:17.404Z
Learning: Validate and enforce React 19 compatibility across monorepo workspaces. Since Medusa UI supports React 19 via root package.json overrides and Medusa Cloud prerequisites show React 19 overrides for npm workspaces, ensure workspace root and all relevant package.json files align with React 19 (18+ requirement is satisfied). When reviewing, verify that overrides exist in the root package.json and that dependent packages in apps or packages directories declare React 19 (or compatible) in their peerDependencies or dependencies as appropriate for workspace usage.
Applied to files:
libs/storefront-data/package.json
🔇 Additional comments (1)
libs/storefront-data/package.json (1)
284-286: LGTM on JSON structure / commas for this block.The
devDependenciesentries shown (vitestthen the two Medusa packages, with the final entry lacking a trailing comma) appear to be valid JSON and consistent within the snippet.
BleedingDev
approved these changes
Apr 29, 2026
This was referenced Jun 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit