feat(table): support external reactivity binding#6237
feat(table): support external reactivity binding#6237riccardoperra wants to merge 9 commits intoalphafrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit f8a9b2b
☁️ Nx Cloud last updated this comment at |
riccardoperra
force-pushed
the
feat/native-reactivity
branch
from
5d74b34 to
20e26ec
Compare
riccardoperra
force-pushed
the
feat/native-reactivity
branch
2 times, most recently
from
e54fed5 to
fc27ad3
Compare
riccardoperra
force-pushed
the
feat/native-reactivity
branch
from
fc27ad3 to
5a5be8b
Compare
![nx-cloud[bot]](https://avatars.github.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We add the missing import { solidReactivity } from './signals' to packages/solid-table/src/createTable.ts, which fixes the Cannot find name 'solidReactivity' TypeScript error introduced when the PR refactored native reactivity bindings into a separate signals.ts file. This also resolves the knip "unused file" warning for signals.ts, as the file is now reachable from createTable.ts.
Tip
✅ We verified this fix by re-running @tanstack/solid-table:test:types, table:test:knip.
diff --git a/packages/solid-table/src/createTable.ts b/packages/solid-table/src/createTable.ts
index 09790fc79..fe62fde30 100644
--- a/packages/solid-table/src/createTable.ts
+++ b/packages/solid-table/src/createTable.ts
@@ -2,6 +2,7 @@ import { constructTable } from '@tanstack/table-core'
import { createComputed, getOwner, mergeProps, untrack } from 'solid-js'
import { shallow, useSelector } from '@tanstack/solid-store'
import { FlexRender } from './FlexRender'
+import { solidReactivity } from './signals'
import type { Atom, ReadonlyAtom } from '@tanstack/solid-store'
import type { Accessor, JSX } from 'solid-js'
import type {
Or Apply changes locally with:
npx nx-cloud apply-locally lZFc-mprV
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
1 participant
Allows
constructTableto support a newreactivityfields used by adapters to pass custom signals implementation