Skip to content

fix: fix build issues for windows os#1

Merged
rmannibucau merged 1 commit into
Talend:masterfrom
chmyga:fix/build_problems
Oct 20, 2017
Merged

fix: fix build issues for windows os#1
rmannibucau merged 1 commit into
Talend:masterfrom
chmyga:fix/build_problems

Conversation

@chmyga

@chmyga chmyga commented Oct 19, 2017

Copy link
Copy Markdown
Contributor
  • Fix tests

  • Fix maven filename for windows

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

Build failed on Windows OS before the changes were made

What does this PR adds (design/code thoughts)?

PR adds fixes for builds on windows OS

* Fix tests

* Fix maven filename for windows
@rmannibucau rmannibucau merged commit 6f0babb into Talend:master Oct 20, 2017
@chmyga chmyga deleted the fix/build_problems branch November 13, 2017 09:45
rmannibucau pushed a commit that referenced this pull request Apr 3, 2019
acatoire pushed a commit that referenced this pull request May 9, 2023
Elasticsearch, HDFS, S3, BigQuery and SimpleFile IOs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants