[#13304] Refactoring for Unit Test Access Controls - #13404
Merged
Conversation
… CAN_VIEW_STUDENT_IN_SECTIONS
…ActionTest helpers
…ub.com/Rockernun/teammates into test/refactor/sqlui-get-student-action-get-students-action
…ss tests - Add stubSelfLookupAsSameCourse() and stubSelfLookupAsOtherCourse() - Each helper binds the login gid to student.account.googleId and sets student.course appropriately
…ub.com/Rockernun/teammates into test/refactor/sqlui-get-student-action-get-students-action
…ifyOnlyLoggedInUsersCanAccess
- Rename test method names to satisfy Method name rule (remove extra underscores / confirm to pattern) - Add trailing commas in array initializers to satisfy ArrayTrailingComma
- To satisfy PMD - Keep its creation scoped to setUp as a local
…ntent param builder
samuelfangjw
approved these changes
Mar 13, 2026
samuelfangjw
added
the
c.Task
WeeJean
pushed a commit
to WeeJean/teammates
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #13304
Outline of Solution
This PR refactors access-control unit tests to rely on the high-level and mid-level helper methods from BaseActionTest, reducing duplication and clarifying intent. I also split scenarios into narrowly scoped tests so each file exercises one behavior per test.
The refactored files are:
Notes for reviewers
Introduced focused stubbing utilities in GetStudentActionTest to ensure consistent entity ↔ course binding during self-lookup flows:
Open to moving/renaming the new stubbing helpers to a shared location if preferred. If there are more appropriate BaseActionTest helpers I missed, I’m happy to switch over. Feedback on test naming and assertion granularity is welcome😄