Gate search compatibility on result overlap - #1750
Merged
Merged
Conversation
cjmyers
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
SBOLExplorer and sbol-db use different search and ranking implementations. Exact result counts, ordering, and page contents are therefore not compatibility requirements.
The previous policy failed even though both backends passed their independent full-corpus conformance gates. The new policy tests the intended contract: both implementations must return a significantly overlapping set of relevant results without requiring identical behavior.
Jaccard overlap penalizes first pages dominated by unrelated results while allowing reasonable implementation-specific differences.
Validation
python3 -m unittest tests/search-backends/test_compare_reports.py tests/search-backends/test_run_conformance.pypython3 -m py_compile tests/search-backends/compare-reports.py tests/search-backends/test_compare_reports.py tests/test_functions.py tests/test_explorer_search.py tests/test_root.pygit diff --checkAll seven focused unit tests pass.