docs(sign): document signature placement and field selection - #123
Open
samuelsl27 wants to merge 1 commit into
Open
docs(sign): document signature placement and field selection#123samuelsl27 wants to merge 1 commit into
samuelsl27 wants to merge 1 commit into
Conversation
The visible-signature section said the box "appears on a chosen page showing the signer name, signing date, and reason", which is now incomplete on three counts: the box can be placed anywhere on the page, its contents are chosen from fourteen certificate fields, and it can be repeated across every page. Documents the every-page option with a caution rather than a plain description, because the honest version of it is easy to miss: only the drawn-on page is really signed and the rest carry a mark that no validator will report. Readers finding that out from the document rather than from the UI is the wrong way round. Accompanies Stirling-Tools/Stirling-PDF#7262. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
@samuelsl27 is attempting to deploy a commit to the Stirling-PDF Team on Vercel. A member of the Team first needs to authorize it. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the signature changes proposed in Stirling-Tools/Stirling-PDF#7262.
The visible-signature section currently reads:
That is now incomplete on three counts. The box can be placed anywhere on the page rather than only on a chosen page, its contents are picked from fourteen certificate fields rather than three fixed ones, and it can optionally be repeated across every page.
Three subsections added:
:::caution, because the honest version is easy to miss: only the drawn-on page is really signed, and the marks on the other pages are not signatures. Readers should learn that here rather than discovering it later.Timing: the code PR is still under review, so this may need adjusting if the approach changes there — in particular the every-page option, which is the part most likely to be dropped. Happy to hold this until #7262 settles, or to amend it alongside any changes requested there.