Skip to content

fix release when timestamped tag is used#148

Open
monotek wants to merge 3 commits into
mainfrom
fix-timestamp-release
Open

fix release when timestamped tag is used#148
monotek wants to merge 3 commits into
mainfrom
fix-timestamp-release

Conversation

@monotek
Copy link
Copy Markdown
Member

@monotek monotek commented Jun 5, 2026

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

Signed-off-by: André Bauer <andre.bauer@staffbase.com>
@monotek monotek requested a review from Copilot June 5, 2026 14:41
@monotek monotek marked this pull request as ready for review June 5, 2026 14:42
@monotek monotek requested review from a team as code owners June 5, 2026 14:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes release retagging when docker-tag-timestamp is enabled by ensuring a stable <prefix>-<short-sha> tag is still pushed alongside the timestamped branch tag, so the release retag step can find the source image by commit SHA.

Changes:

  • Update tag generation to emit an additional legacy <prefix>-<short-sha> alias tag in tag_list when timestamped tags are enabled.
  • Add Bats tests to validate tag_list includes (or does not include) the alias tag depending on the timestamp flag.
  • Document the additional alias tag behavior in the README (Flux ignores it via the filter pattern).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
scripts/generate-tags.sh Adds ALIAS_TAG and appends it to TAG_LIST when timestamped tags are enabled, preserving the release retag lookup tag.
tests/generate-tags.bats Adds coverage for the new alias tag behavior in tag_list for timestamped vs non-timestamped branch tags.
README.md Documents that timestamp mode also pushes the legacy <prefix>-<short-sha> tag and explains why Flux ignores it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/generate-tags.sh Outdated
Comment thread README.md Outdated
monotek and others added 2 commits June 5, 2026 16:48
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants