fix release when timestamped tag is used#148
Open
monotek wants to merge 3 commits into
Open
Conversation
Signed-off-by: André Bauer <andre.bauer@staffbase.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes release retagging when docker-tag-timestamp is enabled by ensuring a stable <prefix>-<short-sha> tag is still pushed alongside the timestamped branch tag, so the release retag step can find the source image by commit SHA.
Changes:
- Update tag generation to emit an additional legacy
<prefix>-<short-sha>alias tag intag_listwhen timestamped tags are enabled. - Add Bats tests to validate
tag_listincludes (or does not include) the alias tag depending on the timestamp flag. - Document the additional alias tag behavior in the README (Flux ignores it via the filter pattern).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/generate-tags.sh | Adds ALIAS_TAG and appends it to TAG_LIST when timestamped tags are enabled, preserving the release retag lookup tag. |
| tests/generate-tags.bats | Adds coverage for the new alias tag behavior in tag_list for timestamped vs non-timestamped branch tags. |
| README.md | Documents that timestamp mode also pushes the legacy <prefix>-<short-sha> tag and explains why Flux ignores it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Checklist