Skip to content

Delete sensor from process container before terminating#2187

Merged
manasdk merged 1 commit intoStackStorm:masterfrom
vcabbage:remove_sensor_before_stopping
Nov 9, 2015
Merged

Delete sensor from process container before terminating#2187
manasdk merged 1 commit intoStackStorm:masterfrom
vcabbage:remove_sensor_before_stopping

Conversation

@vcabbage
Copy link
Copy Markdown
Contributor

@vcabbage vcabbage commented Nov 9, 2015

  • Eliminates a race condition where the process could be respawned before _delete_sensor is called.

@manasdk
Copy link
Copy Markdown
Contributor

manasdk commented Nov 9, 2015

LGTM

+1

@manasdk
Copy link
Copy Markdown
Contributor

manasdk commented Nov 9, 2015

/cc Kami - Do you want to take a look?

@Kami
Copy link
Copy Markdown
Member

Kami commented Nov 9, 2015

Thanks good catch - the change looks good to me.

manasdk added a commit that referenced this pull request Nov 9, 2015
Delete sensor from process container before terminating
@manasdk manasdk merged commit 5a0b0c2 into StackStorm:master Nov 9, 2015
@Kami
Copy link
Copy Markdown
Member

Kami commented Nov 9, 2015

@manasdk Since you merged the PR, can you please also update changelog?

@Kami
Copy link
Copy Markdown
Member

Kami commented Nov 10, 2015

Updated the changelog and also cherry-picked this fix onto v1.1.1 branch.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants