-
Notifications
You must be signed in to change notification settings - Fork 0
docs: finalize feat_data_table_primitive — move to implemented_features #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -28,4 +28,17 @@ | |||||
| - Phases covered: single-phase delivery per Locked Decision #4. No deferred phases. | ||||||
|
|
||||||
| ## Implementation | ||||||
| - Status: Not started | ||||||
| - Status: Complete | ||||||
| - Date: 2026-05-16 | ||||||
| - PR: [#126](https://github.com/SoundMindsAI/relyloop/pull/126) (squash commit `d6115b3`, merged 2026-05-16) | ||||||
| - CI: all 7 checks green on cycle 4 — backend lint + typecheck + tests + coverage, backend unit fast lane, docker buildx, frontend lint + typecheck + tests + build, gitleaks, secrets files guard, smoke (operator-path E2E) | ||||||
| - Stories completed: 28 / 28 (Epic 1: 5 backend stories, Epic 2: 13 primitive stories, Epic 3: 9 table-migration stories incl. Story 3.9 inheritor, Epic 4: 2 docs/idea-capture stories) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is an arithmetic discrepancy in the story count. The breakdown provided (5 + 13 + 9 + 2) sums to 29 stories, but the total is listed as 28 / 28. Based on the implementation plan which includes stories 3.1 through 3.9, the total should be 29.
Suggested change
|
||||||
| - Cross-model review: | ||||||
| - 3 Epic-2 phase-gate GPT-5.5 cycles (15 + 7 + 3 findings) — converged with 13 fixes applied, 7 deferred to `chore_data_table_primitive_followups`, 4 rejected with cited counter-evidence | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The findings tally in this line is inconsistent. The cycle breakdown
Suggested change
|
||||||
| - 1 Epic-3 phase-gate GPT-5.5 cycle (7 findings) — 5 accepted + fixed, 2 rejected with cited counter-evidence | ||||||
| - Final cross-model GPT-5.5 review on full PR diff: 2 findings — 1 accepted + fixed (`test-llm-rater` fixture), 1 deferred to `bug_cursor_decode_value_validation` | ||||||
| - Gemini Code Assist: 7 line-level findings, all 7 accepted + fixed (commit `acfd304`). Adjudication summary posted as PR comment. | ||||||
| - Deferred follow-ups captured: | ||||||
| - [`feat_fts_rank_ordering_mvp2`](../feat_fts_rank_ordering_mvp2/idea.md) — rank-ordered FTS results (per spec §16) | ||||||
| - [`chore_data_table_primitive_followups`](../chore_data_table_primitive_followups/idea.md) — 6 review-cycle items | ||||||
| - [`bug_cursor_decode_value_validation`](../bug_cursor_decode_value_validation/idea.md) — cursor payload validation | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dashboard entry for
feat_data_table_primitivehas two metadata issues:idea.mdandfeature_spec.mdboth document a dependency onfeat_contextual_help.