Sorting a list with checked checkboxes causes intentionally unchecked boxes to revert to checked

[gavbaa]

Example: http://jsbin.com/belacoreki/edit?html,js,output

Reproduction steps:

1. Uncheck "ID"
2. Drag the sort handle anywhere in the list.

What should happen: List is reordered with checkboxes maintaining their current state (ID unchecked)

What happens: List is reordered with the ID checkbox being re-checked.

Verified issue against master and 1.5.1 release. Regression from 1.4.2, verified does not have this issue (you can change the CDN link to https://cdnjs.cloudflare.com/ajax/libs/Sortable/1.4.2/Sortable.js to verify).

[LeventeHudak]

Just stumbled upon the same issue and can also validate it was working in v1.4.2.

[ohepworthbell]

I have also noted the issue in v1.5.1

[jmt75200]

Still an issue with v1.5.1
http://jsbin.com/dukiqafeto/edit?html,js,output

But is working with v1.4.2

[cbwiedel]

I'm also running into the same issue.

[danimalia]

I'm seeing this too, using sortablejs@1.6.0 and angular-sortablejs@2.0.6. It only happens if you specify a drag handle, fwiw. I just reverted to sortablejs@1.4.2 and the issue was resolved.

[gwenael74]

To solve this bug,
i put in comment the line "el.checked=true" in the function "_nulling":
savedInputChecked.forEach(function (el) {
//el.checked = true;
});

[thetuningspoon]

Problem for me as well

[kaltar]

This is a problem on anything that uses checkboxes.

[lbowers]

I'm experiencing this too. Took me some time to realise Sortable was the cause of the problem.

Clicking on the handle (or any control within the handle) causes any toggled checkboxes to revert to their checked state. Any quick fix, without changing the source code, until this is fixed?

[ml054]

@lbowers for quick fix just use version 1.4.2 unless you need some of the features available in latest (buggy version). It helped in my case. Maybe it isn't best solution but works.

[ststaynov]

@RubaXa Can this code be removed from master since it causes this bug?

[ianshade]

To confirm it is related to handle and filter options
Here is a bin without handle set and checkboxes work as expected:
http://jsbin.com/vuxilaqiwi/edit?html,js,output
Here with filters (checkbox in a filter) and re-checking again occurs:
http://jsbin.com/rimehumawo/1/edit?html,js,output

Has anybody investigated if the proposed solution - removing el.checked = true; - is a valid solution and will not mess with anything or if there is any other solution that could make into PR?

[n1474335]

Any update on this? It's causing a lot of problems in CyberChef.