refactor: upgrade error handling and replace print with standard logging in scripts/openai_compat_live_check.py#349
Merged
Soju06 merged 2 commits intoSoju06:mainfrom Apr 8, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors scripts/openai_compat_live_check.py to improve runtime observability by switching from print() to Python’s standard logging and by narrowing overly broad exception handling.
Changes:
- Added a module logger and configured basic logging in
main(). - Replaced runtime
print()statements withlogger.info()/logger.error(). - Narrowed exception handling in
_error_detail()when extracting response bodies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
@all-contributors please add @Felix201209 for code |
Contributor
|
I've put up a pull request to add @Felix201209! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances observability and safety by removing broad exception catches and integrating proper logging, ensuring safer production deployments.
Changes include: