fix: support mongoose v9 embeddedSchemaType instead of caster - #119
Open
loresclement wants to merge 1 commit into
Open
fix: support mongoose v9 embeddedSchemaType instead of caster#119loresclement wants to merge 1 commit into
loresclement wants to merge 1 commit into
Conversation
|
Can we merge and deploy this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mongoose v9 removed SchemaType.caster. This causes AdminJS to crash when handling arrays of subdocuments.
This PR adds backward-compatible support for both:
Mongoose <= 8 using caster
Mongoose 9+ using embeddedSchemaType / fallbacks
Fixes runtime error:
TypeError: Cannot destructure property 'instance' of 'this.mongoosePath.caster' as it is undefined