Conversation
Member
|
Thanks for debugging this, but that seems like a more problematic synchronization issue, that I wouldn't want to solely solve with a workaround in @cmeissl Maybe we should set |
Author
|
Thanks! Yes, I agree the current solution is a bit unfortunate. This is definitely a driver bug but it seems that Nvidia is not doing anything 🙁 Happy to test on my end if you have other solutions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce an option to enable 3 buffer rotation. Currently,
Swapchain::acquirereturns the first free slot, which is nearlly always the most recent released buffer. The nvidia driver appears to keep reading the buffer for a short while. Holding the buffer for 1 frame longer will avoid flickering.This matches the behavior in Hyprland, which does not exhibit flickering.
This fixes: #1862
I use claude code + fable to understand the implementation differences between smithay and hyprland and draft the PR
Checklist