fix: incorrectly sending axis_discrete events#2069
Draft
MithicSpirit wants to merge 3 commits into
Draft
Conversation
Allows manual consumer control over sending axis_discrete events and fixes the default behavior to prevent hiding events. See Smithay#2068
improve default behavior
only force axis_discrete for discrete event sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows manual consumer control over sending
axis_discreteevents and fixes the default behavior to prevent hiding events.This is a sample implementation of the suggestions in #2068, and I'm not sure that this is the path that should be taken. I would appreciate any feedback and ideas on how this could be handled (although general ideas should probably be discussed in the issue instead).
Fixes #2068.
Checklist