Update test-e2e script - #431
Closed
miry wants to merge 1 commit into
Closed
Conversation
miry
force-pushed
the
test-e2e-reformat
branch
from
September 3, 2022 23:45
77b901a to
0a38ede
Compare
miry
marked this pull request as ready for review
September 3, 2022 23:45
miry
force-pushed
the
test-e2e-reformat
branch
from
September 3, 2022 23:51
0a38ede to
a96d18d
Compare
barthalion
reviewed
Sep 5, 2022
barthalion
left a comment
barthalion
left a comment
Member
There was a problem hiding this comment.
Just some nitpicks, feel free to ignore if they don't make sense in wider context.
miry
force-pushed
the
test-e2e-reformat
branch
2 times, most recently
from
September 5, 2022 13:00
4995733 to
ad8e399
Compare
barthalion
approved these changes
Sep 5, 2022
miry
force-pushed
the
test-e2e-reformat
branch
2 times, most recently
from
September 5, 2022 13:40
9116a52 to
51c6c2f
Compare
Extract execution of benchmark script to function. Use alias for command lines. Extract trap eval string to function.
miry
force-pushed
the
test-e2e-reformat
branch
from
September 5, 2022 13:40
51c6c2f to
29685f4
Compare
Contributor
Author
|
merged in commit 29685f4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract execution of benchmark script to function.
Use alias for command lines.
Extract trap eval string to function.