Add string representation of Direction. - #430
Merged
Merged
Conversation
miry
marked this pull request as ready for review
September 3, 2022 22:58
miry
force-pushed
the
direction-string
branch
from
September 3, 2022 23:34
73eeb18 to
1ba53e2
Compare
miry
requested review from
a team,
dabealu,
frightenedmonkey and
yuseinishiyama
and removed request for
a team
September 5, 2022 11:58
thepwagner
approved these changes
Sep 6, 2022
Allow to print Direction in human form. Extract Direction struct to a separate file. Add tests to cover Direction to string. Parse direction from string with a new method stream.ParseDirection. It returns direction or error if could not parse.
miry
force-pushed
the
direction-string
branch
from
September 6, 2022 12:16
1ba53e2 to
77dfc2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to print Direction in human form.
Extract Direction struct to a separate file.
Add tests to cover Direction to string.
Add method to detect Direction from string.