Update toxiproxy.NewProxy signature to support common attributes - #418
Merged
Conversation
miry
force-pushed
the
new-proxy-signature
branch
2 times, most recently
from
August 27, 2022 14:07
f915ee6 to
3c8c029
Compare
miry
marked this pull request as ready for review
August 27, 2022 14:09
NewProxy always uses 4 lines to initialize name, listen and upstream addresses. Combine them in single initialization via arguments.
miry
force-pushed
the
new-proxy-signature
branch
from
August 27, 2022 14:28
3c8c029 to
d10a921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewProxy always uses 4 lines to initialize name, listen and upstream addresses.
Combine them in single initialization via arguments.