Issues with add then remove - #559
Closed
lemonmade wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Here was my original investigation of why this only affected the remote-ui adaptor. Both of them show some manual instrumentation from me loading the page on that example, pressing button 1, reversing the buttons, then pressing button 1 again: Messages for Remote DOM
Messages from Remote UI adaptor
|
lemonmade
commented
Apr 1, 2025
| release(child.properties.peek()); | ||
| if (release) { | ||
| if ('properties' in child) release(child.properties.peek()); | ||
| if ('eventListeners' in child) release(child.eventListeners.peek()); |
Contributor
Author
There was a problem hiding this comment.
The absence of this line is why this whole thing worked before — we were not releasing the function references attached as event listeners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.