docs: sync after #88 (add effective-sizing to docs-site API table) - #93
Closed
Sev7eNup wants to merge 1 commit into
Closed
docs: sync after #88 (add effective-sizing to docs-site API table)#93Sev7eNup wants to merge 1 commit into
Sev7eNup wants to merge 1 commit into
Conversation
This was referenced Aug 1, 2026
Owner
Author
|
Superseded by #103, which carries the The other two changes here are not correct and were deliberately left out:
|
hshalab
pushed a commit
to hshalab/NodePilot
that referenced
this pull request
Aug 4, 2026
Picked out of the open docs-sync PR (Sev7eNup#93), which also carried two regressions that are deliberately left behind: it doubled the backslashes in the credential curl example (CONTOSO\svc-winrm renders as two literal backslashes, not one), and it stripped the trailing newline from the file. Only the endpoint addition is correct - GET /api/admin/settings/effective-sizing exists in AdminSettingsController.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #88 ("Size the engine from detected hardware unless manual tuning is on") introduced
GET /api/admin/settings/effective-sizing, which reports the plan actually in force and which hardware constraint produced each value (Cpu/Ram/Floor/Ceiling/Manual).The endpoint was already documented in
docs/claude-reference.md(line 577) and the root admin-settings reference, but was missing from the docs-site endpoint table insrc/nodepilot-docs-ui/content/api/endpoints.md.Change
src/nodepilot-docs-ui/content/api/endpoints.md— Settings row in the admin-area endpoint table:No other files changed. Driven by #88.
Generated by Claude Code