Automated review finding for PR #88 — "Size the engine from detected hardware unless manual tuning is on"
Author: @Sev7eNup · Status: open
The PR is otherwise strong: the sizing arithmetic is a pure PerformanceSizing function in Core with a wide test matrix (memory-budget invariant, floors/ceilings, monotonicity, manual-mode passthrough, CPU-only fallback), DE+EN i18n is complete, and the docs surfaces are synced. One convention gap:
This is an automated PR-review finding and needs triage. Low-severity notes, if any, are intentionally omitted.
Automated review finding for PR #88 — "Size the engine from detected hardware unless manual tuning is on"
Author: @Sev7eNup · Status: open
The PR is otherwise strong: the sizing arithmetic is a pure
PerformanceSizingfunction in Core with a wide test matrix (memory-budget invariant, floors/ceilings, monotonicity, manual-mode passthrough, CPU-only fallback), DE+EN i18n is complete, and the docs surfaces are synced. One convention gap:src/NodePilot.Api/Controllers/AdminSettingsController.cs— the new endpointGET /api/admin/settings/effective-sizing(plusEffectiveSizingDto) ships with a frontend client (adminSettings.getEffectiveSizing) but no parallel CLI client. The 25 changed files touch noNodePilot.Cliproject at all. CLAUDE.md states "Jeder neue API-Endpoint braucht beide Clients" andsrc/NodePilot.Cli/CLAUDE.mdstates "Neuer API-Endpoint → parallel Methode inNodePilotApiClient.cs+ Command anlegen." There is direct precedent for admin-settings diagnostics in the CLI:np settings system-infoandnp settings statusalready wrap the analogous read-only endpoints. Suggestion: add aGetEffectiveSizingAsyncmethod toNodePilot.Cli/Api/NodePilotApiClient.cs, a mirrored DTO underCli/Api/Dtos/, and annp settings effective-sizingcommand inSettingsCommands.cs. (MCP has no settings tools at all, so the MCP-mirror rule does not apply here — CLI only.)This is an automated PR-review finding and needs triage. Low-severity notes, if any, are intentionally omitted.