Skip to content

PR-Review #88: new effective-sizing endpoint missing its parallel CLI client #89

Description

@Sev7eNup

Automated review finding for PR #88 — "Size the engine from detected hardware unless manual tuning is on"
Author: @Sev7eNup · Status: open

The PR is otherwise strong: the sizing arithmetic is a pure PerformanceSizing function in Core with a wide test matrix (memory-budget invariant, floors/ceilings, monotonicity, manual-mode passthrough, CPU-only fallback), DE+EN i18n is complete, and the docs surfaces are synced. One convention gap:

  • [medium] src/NodePilot.Api/Controllers/AdminSettingsController.cs — the new endpoint GET /api/admin/settings/effective-sizing (plus EffectiveSizingDto) ships with a frontend client (adminSettings.getEffectiveSizing) but no parallel CLI client. The 25 changed files touch no NodePilot.Cli project at all. CLAUDE.md states "Jeder neue API-Endpoint braucht beide Clients" and src/NodePilot.Cli/CLAUDE.md states "Neuer API-Endpoint → parallel Methode in NodePilotApiClient.cs + Command anlegen." There is direct precedent for admin-settings diagnostics in the CLI: np settings system-info and np settings status already wrap the analogous read-only endpoints. Suggestion: add a GetEffectiveSizingAsync method to NodePilot.Cli/Api/NodePilotApiClient.cs, a mirrored DTO under Cli/Api/Dtos/, and an np settings effective-sizing command in SettingsCommands.cs. (MCP has no settings tools at all, so the MCP-mirror rule does not apply here — CLI only.)

This is an automated PR-review finding and needs triage. Low-severity notes, if any, are intentionally omitted.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions