SeldonIO · RobertSamoilescu · Jun 7, 2024 · Jun 7, 2024 · Jun 7, 2024
diff --git a/mlserver/metrics/server.py b/mlserver/metrics/server.py
@@ -1,5 +1,6 @@
 import uvicorn
 import os
+import signal
 
 from typing import Optional, TYPE_CHECKING
 
@@ -72,5 +73,10 @@ def _get_config(self):
         return uvicorn.Config(self._app, **kwargs)
 
     async def stop(self, sig: Optional[int] = None):
+        if sig is None:
+            # `sig` is no longer optional for `handle_exit` in
+            # latest `uvicorn`
+            sig = signal.SIGINT
+
         await stop_metrics(self._settings, os.getpid())
         self._server.handle_exit(sig=sig, frame=None)
diff --git a/mlserver/rest/server.py b/mlserver/rest/server.py
@@ -1,4 +1,5 @@
 import uvicorn
+import signal
 
 from ..settings import Settings
 from ..handlers import DataPlane, ModelRepositoryHandlers, get_custom_handlers
@@ -96,4 +97,9 @@ def _get_config(self):
         return uvicorn.Config(self._app, **kwargs)
 
     async def stop(self, sig: Optional[int] = None):
+        if sig is None:
+            # `sig` is no longer optional for `handle_exit` in
+            # latest `uvicorn`
+            sig = signal.SIGINT
+
         self._server.handle_exit(sig=sig, frame=None)
diff --git a/poetry.lock b/poetry.lock
diff --git a/runtimes/alibi-detect/poetry.lock b/runtimes/alibi-detect/poetry.lock
diff --git a/runtimes/alibi-explain/poetry.lock b/runtimes/alibi-explain/poetry.lock
diff --git a/runtimes/catboost/poetry.lock b/runtimes/catboost/poetry.lock
diff --git a/runtimes/huggingface/poetry.lock b/runtimes/huggingface/poetry.lock
diff --git a/runtimes/lightgbm/poetry.lock b/runtimes/lightgbm/poetry.lock
diff --git a/runtimes/mlflow/poetry.lock b/runtimes/mlflow/poetry.lock
diff --git a/runtimes/mllib/poetry.lock b/runtimes/mllib/poetry.lock
diff --git a/runtimes/sklearn/poetry.lock b/runtimes/sklearn/poetry.lock
diff --git a/runtimes/xgboost/poetry.lock b/runtimes/xgboost/poetry.lock