Fixed openapi dataplane.yaml#1752
Merged
Merged
Conversation
RobertSamoilescu
force-pushed
the
fix/dataplane-yaml
branch
from
6d92a4e to
4486a5c
Compare
jesse-c
reviewed
May 10, 2024
jesse-c
left a comment
jesse-c
left a comment
Contributor
There was a problem hiding this comment.
LGTM though could you rebase on the latest master, due to Pydantic v2 support going in? If there's a hairy rebase, I'm happy to tackle that.
RobertSamoilescu
force-pushed
the
fix/dataplane-yaml
branch
from
f7ef722 to
f5f4d94
Compare
RobertSamoilescu
force-pushed
the
fix/dataplane-yaml
branch
from
f5f4d94 to
5c049d1
Compare
Contributor
|
The 2 failed jobs are flaky. I've just started a re-run of them. |
This was referenced May 15, 2024
jesse-c
pushed a commit
that referenced
this pull request
May 15, 2024
This is a follow-up to #1752 and supersedes #1759. It's understood that `string` type is no longer being treated as a list by Pydantic. `bytes` should be. The code generator seems aware of the `bytes` type [1][2]. [1] https://github.com/koxudaxi/datamodel-code-generator/blob/fcab9a4d555d4b96d64bb277f974bb7507982fb2/datamodel_code_generator/types.py#L536-L569 [2] https://github.com/koxudaxi/datamodel-code-generator/blob/fcab9a4d555d4b96d64bb277f974bb7507982fb2/datamodel_code_generator/types.py#L624-L640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a syntax error in the
dataplane.yaml.