Skip to content

build: Upgrade stale packages (fastapi, starlette, tensorflow, torch)#1603

Merged
sakoush merged 15 commits into
SeldonIO:masterfrom
sakoush:INFRA-767/upgrade_fastapi
Mar 1, 2024
Merged

build: Upgrade stale packages (fastapi, starlette, tensorflow, torch)#1603
sakoush merged 15 commits into
SeldonIO:masterfrom
sakoush:INFRA-767/upgrade_fastapi

Conversation

@sakoush

@sakoush sakoush commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

This is a change to upgrade deps of mlserver that was triggered by initially trying to update fastapi to a recent version. Due to some deps clashed we had to:

  • remove py3.8 support: a few packages already require py3.9 as minimum version (e.g. numpy and tensorflow). py3.8 EoL is October 2024.
  • update packages to more recent versions e.g. numpy 1.26.4, tensorflow 2.14.1 and torch 2.2.1.
  • update mypy to 1.8.0 to fix issues from starlette 0.36.3 upgrade
  • fix tests from fastapi upgrade to 1.109.2

For a full list of changes check pyproject.toml and poetry.lock

@sakoush sakoush marked this pull request as draft March 1, 2024 10:34
@sakoush sakoush marked this pull request as ready for review March 1, 2024 10:49
@sakoush sakoush requested a review from RafalSkolasinski March 1, 2024 10:50
@sakoush sakoush changed the title build: Upgrade state packages (fastapi, starlette, tensorflow, torch) build: Upgrade stale packages (fastapi, starlette, tensorflow, torch) Mar 1, 2024

@RafalSkolasinski RafalSkolasinski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just clarification on some choices would be good :)

Comment thread pyproject.toml Outdated
Comment thread pyproject.toml
@sakoush

sakoush commented Mar 1, 2024

Copy link
Copy Markdown
Contributor Author

skipping flaky tests for now

@sakoush sakoush merged commit 05d6a0c into SeldonIO:master Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants