Local response cache implementation#1440
Conversation
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
|
PTAL @adriangonz 🙂 |
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
bb43988 to
03a6cec
Compare
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
d8e7586 to
954c2cb
Compare
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
7e2cfa4 to
8a13e64
Compare
adriangonz
left a comment
There was a problem hiding this comment.
Nice one @SachinVarghese! It's great to see you back contributing some good stuff to MLServer!
I've added a few comments, but would be good to hear your thoughts on those. Besides that, it would also be great if you could add some tests around the caching behaviour.
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
80713a0 to
43dfc1c
Compare
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
|
I have made most of the suggested changes now, and all the CI tests should be passing. Please review. |
|
I think for this one we probably want to add two types of tests:
|
67174eb to
7d865c0
Compare
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
7d865c0 to
ffc5ae1
Compare
Signed-off-by: Sachin Varghese <sachin.mathew31@gmail.com>
|
I have added a few tests for the local cache and data plane component now, please review. |
adriangonz
left a comment
There was a problem hiding this comment.
Nice one @SachinVarghese ! Thanks for adding those changes in.
This should be good to go from my side. 👍
|
Awesome and thanks for reviewing/ almost co-authoring 😄 Will wait for other reviews. |
This PR introduces basic local response caching as per the issue #1023
The implementation is inspired by the triton equivalent local cache https://github.com/triton-inference-server/local_cache