Skip to content

Add inference params support to MLFlow's custom invocation endpoint (…#1375

Merged
adriangonz merged 1 commit into
SeldonIO:masterfrom
M4nouel:feature/infer_params_mlflow_custom_invocation_endpoint
Sep 6, 2023
Merged

Add inference params support to MLFlow's custom invocation endpoint (…#1375
adriangonz merged 1 commit into
SeldonIO:masterfrom
M4nouel:feature/infer_params_mlflow_custom_invocation_endpoint

Conversation

@M4nouel

@M4nouel M4nouel commented Sep 3, 2023

Copy link
Copy Markdown
Contributor
  • Adds inference params support to MLFlow's custom invocation endpoint (Add inference params support to MLFlow's custom invocation endpoint #1374)
  • Fixes FutureWarning: ``mlflow.pyfunc.scoring_server.infer_and_parse_json_input`` is deprecated since 2.6.0. This method will be removed in a future release. Use ``infer_and_parse_data`` instead.
  • Adds tests of MLFlow runtime invocation method.

@adriangonz adriangonz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @M4nouel ,

Thanks for the contribution - that's a great PR! Self-contained, properly tested, addressing some warnings... nice job! 🚀

Changes look good from my side, so once the tests are green this should be good to go 👍

@M4nouel

M4nouel commented Sep 6, 2023

Copy link
Copy Markdown
Contributor Author

Hi @adriangonz ,

Thank you !
I have a linting problem, I'll fix it and rebase my branch!

@M4nouel M4nouel force-pushed the feature/infer_params_mlflow_custom_invocation_endpoint branch from e07a6cb to 2045737 Compare September 6, 2023 15:36
@adriangonz adriangonz merged commit a7cf4ee into SeldonIO:master Sep 6, 2023
adriangonz pushed a commit that referenced this pull request Sep 7, 2023
#1375)

Co-authored-by: Manuel Laventure <mlaventure@oppscience.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants