feat(huggingface): Merge model settings#1337
Merged
jesse-c merged 2 commits intoAug 18, 2023
Merged
Conversation
adriangonz
approved these changes
Aug 16, 2023
adriangonz
left a comment
adriangonz
left a comment
Contributor
There was a problem hiding this comment.
Nice one! From my side, changes look great 👍
added 2 commits
August 17, 2023 10:45
If settings for the model are provided in both the `model-settings.json` *and* environment variables, merge them. Precedence is given to environment variables.
The possible types are constrained in what's allowed. Specify this new type that follows those constraints.
Contributor
Author
|
Tested manually in clusters locally and in GKE with SCv1 and an image built by myself and pushed to Docker Hub ( I used a cc: @agrski, @adriangonz |
vtaskow
approved these changes
Aug 18, 2023
vtaskow
left a comment
vtaskow
left a comment
Contributor
There was a problem hiding this comment.
Great work! Nothing more to say
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If settings for the model are provided in both the
model-settings.jsonand environment variables, merge them.Precedence is given to environment variables.
FIXES #1329